mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-18 18:59:44 +00:00
56c4046038
This change allows more fine tuning of driver model based SPI support in SPL and TPL. It is now possible to explicitly enable/disable the DM_SPI support in SPL and TPL via Kconfig option. Before this change it was necessary to use: /* SPI Flash Configs */ #if defined(CONFIG_SPL_BUILD) #undef CONFIG_DM_SPI #undef CONFIG_DM_SPI_FLASH #undef CONFIG_SPI_FLASH_MTD #endif in the ./include/configs/<board>.h, which is error prone and shall be avoided when we strive to switch to Kconfig. The goal of this patch: Provide distinction for DM_SPI support in both U-Boot proper and SPL (TPL). Valid use case is when U-Boot proper wants to use DM_SPI, but SPL must still support non DM driver. Another use case is the conversion of non DM/DTS SPI driver to support DM/DTS. When such driver needs to work in both SPL and U-Boot proper, the distinction is needed in Kconfig (also if SPL version of the driver supports OF_PLATDATA). In the end of the day one would have to support following use cases (in single driver file - e.g. mxs_spi.c): - U-Boot proper driver supporting DT/DTS - U-Boot proper driver without DT/DTS support (deprecated) - SPL driver without DT/DTS support - SPL (and TPL) driver with DT/DTS (when the SoC has enough resources to run full blown DT/DTS) - SPL driver with DT/DTS and SPL_OF_PLATDATA (when one have constrained environment with no fitImage and OF_LIBFDT support). Some boards do require SPI support (with DM) in SPL (TPL) and some only have DM_SPI{_FLASH} defined to allow compiling SPL. This patch converts #ifdef CONFIG_DM_SPI* to #if CONFIG_IS_ENABLED(DM_SPI) and provides corresponding defines in Kconfig. Signed-off-by: Lukasz Majewski <lukma@denx.de> Tested-by: Adam Ford <aford173@gmail.com> #da850-evm Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> [trini: Fixup a few platforms] Signed-off-by: Tom Rini <trini@konsulko.com> |
||
---|---|---|
.. | ||
dm | ||
env | ||
fs | ||
image | ||
lib | ||
log | ||
optee | ||
overlay | ||
py | ||
stdint | ||
trace | ||
bloblist.c | ||
cmd_ut.c | ||
command_ut.c | ||
common.sh | ||
compression.c | ||
Kconfig | ||
Makefile | ||
nokia_rx51_test.sh | ||
print_ut.c | ||
README | ||
run | ||
str_ut.c | ||
time_ut.c | ||
unicode_ut.c | ||
ut.c |
Testing in U-Boot ================= U-Boot has a large amount of code. This file describes how this code is tested and what tests you should write when adding a new feature. Running tests ------------- To run most tests on sandbox, type this: make check in the U-Boot directory. Note that only the pytest suite is run using this command. Some tests take ages to run. To run just the quick ones, type this: make qcheck Sandbox ------- U-Boot can be built as a user-space application (e.g. for Linux). This allows test to be executed without needing target hardware. The 'sandbox' target provides this feature and it is widely used in tests. Pytest Suite ------------ Many tests are available using the pytest suite, in test/py. This can run either on sandbox or on real hardware. It relies on the U-Boot console to inject test commands and check the result. It is slower to run than C code, but provides the ability to unify lots of tests and summarise their results. You can run the tests on sandbox with: ./test/py/test.py --bd sandbox --build This will produce HTML output in build-sandbox/test-log.html See test/py/README.md for more information about the pytest suite. tbot ---- Tbot provides a way to execute tests on target hardware. It is intended for trying out both U-Boot and Linux (and potentially other software) on a number of boards automatically. It can be used to create a continuous test environment. See http://www.tbot.tools for more information. Ad-hoc tests ------------ There are several ad-hoc tests which run outside the pytest environment: test/fs - File system test (shell script) test/image - FIT and legacy image tests (shell script and Python) test/stdint - A test that stdint.h can be used in U-Boot (shell script) trace - Test for the tracing feature (shell script) TODO: Move these into pytest. When to write tests ------------------- If you add code to U-Boot without a test you are taking a risk. Even if you perform thorough manual testing at the time of submission, it may break when future changes are made to U-Boot. It may even break when applied to mainline, if other changes interact with it. A good mindset is that untested code probably doesn't work and should be deleted. You can assume that the Pytest suite will be run before patches are accepted to mainline, so this provides protection against future breakage. On the other hand there is quite a bit of code that is not covered with tests, or is covered sparingly. So here are some suggestions: - If you are adding a new uclass, add a sandbox driver and a test that uses it - If you are modifying code covered by an existing test, add a new test case to cover your changes - If the code you are modifying has not tests, consider writing one. Even a very basic test is useful, and may be picked up and enhanced by others. It is much easier to add onto a test - writing a new large test can seem daunting to most contributors. Future work ----------- Converting existing shell scripts into pytest tests.