mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-06 21:24:29 +00:00
969251a5a4
The cmd "cpu detail" fetches uninitialized cpu feature information
and thus displays wrong / inconsitent details as below.
For eg: FU540-C000 doesn't have any microcode, yet the cmd display's it.
=> cpu detail
1: cpu@1 rv64imafdc
ID = 1, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID
Microcode version 0x0
Device ID 0x0
2: cpu@2 rv64imafdc
ID = 2, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID
Microcode version 0x0
Device ID 0x0
3: cpu@3 rv64imafdc
ID = 3, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID
Microcode version 0x0
Device ID 0x0
4: cpu@4 rv64imafdc
ID = 4, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID
Microcode version 0x0
Device ID 0x0
The L1 cache or MMU entry seen above is also displayed inconsistently.
So initialize cpu information to zero into cpu-uclass itself so that
similar issues can be avoided for other CPU drivers.
We now see correct features as:
=> cpu detail
1: cpu@1 rv64imafdc
ID = 1, freq = 999.100 MHz
2: cpu@2 rv64imafdc
ID = 2, freq = 999.100 MHz
3: cpu@3 rv64imafdc
ID = 3, freq = 999.100 MHz
4: cpu@4 rv64imafdc
ID = 4, freq = 999.100 MHz
Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Bin Meng <bin.meng@windriver.com>
142 lines
2.5 KiB
C
142 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2015 Google, Inc
|
|
* Written by Simon Glass <sjg@chromium.org>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <cpu.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <log.h>
|
|
#include <dm/lists.h>
|
|
#include <dm/root.h>
|
|
#include <linux/err.h>
|
|
|
|
int cpu_probe_all(void)
|
|
{
|
|
struct udevice *cpu;
|
|
int ret;
|
|
|
|
ret = uclass_first_device(UCLASS_CPU, &cpu);
|
|
if (ret) {
|
|
debug("%s: No CPU found (err = %d)\n", __func__, ret);
|
|
return ret;
|
|
}
|
|
|
|
while (cpu) {
|
|
ret = uclass_next_device(&cpu);
|
|
if (ret) {
|
|
debug("%s: Error while probing CPU (err = %d)\n",
|
|
__func__, ret);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int cpu_is_current(struct udevice *cpu)
|
|
{
|
|
struct cpu_ops *ops = cpu_get_ops(cpu);
|
|
|
|
if (ops->is_current) {
|
|
if (ops->is_current(cpu))
|
|
return 1;
|
|
}
|
|
|
|
return -ENOSYS;
|
|
}
|
|
|
|
struct udevice *cpu_get_current_dev(void)
|
|
{
|
|
struct udevice *cpu;
|
|
int ret;
|
|
|
|
uclass_foreach_dev_probe(UCLASS_CPU, cpu) {
|
|
if (cpu_is_current(cpu) > 0)
|
|
return cpu;
|
|
}
|
|
|
|
/* If can't find current cpu device, use the first dev instead */
|
|
ret = uclass_first_device_err(UCLASS_CPU, &cpu);
|
|
if (ret) {
|
|
debug("%s: Could not get CPU device (err = %d)\n",
|
|
__func__, ret);
|
|
return NULL;
|
|
}
|
|
|
|
return cpu;
|
|
}
|
|
|
|
int cpu_get_desc(struct udevice *dev, char *buf, int size)
|
|
{
|
|
struct cpu_ops *ops = cpu_get_ops(dev);
|
|
|
|
if (!ops->get_desc)
|
|
return -ENOSYS;
|
|
|
|
return ops->get_desc(dev, buf, size);
|
|
}
|
|
|
|
int cpu_get_info(struct udevice *dev, struct cpu_info *info)
|
|
{
|
|
struct cpu_ops *ops = cpu_get_ops(dev);
|
|
|
|
if (!ops->get_info)
|
|
return -ENOSYS;
|
|
|
|
/* Init cpu_info to 0 */
|
|
memset(info, 0, sizeof(struct cpu_info));
|
|
|
|
return ops->get_info(dev, info);
|
|
}
|
|
|
|
int cpu_get_count(struct udevice *dev)
|
|
{
|
|
struct cpu_ops *ops = cpu_get_ops(dev);
|
|
|
|
if (!ops->get_count)
|
|
return -ENOSYS;
|
|
|
|
return ops->get_count(dev);
|
|
}
|
|
|
|
int cpu_get_vendor(struct udevice *dev, char *buf, int size)
|
|
{
|
|
struct cpu_ops *ops = cpu_get_ops(dev);
|
|
|
|
if (!ops->get_vendor)
|
|
return -ENOSYS;
|
|
|
|
return ops->get_vendor(dev, buf, size);
|
|
}
|
|
|
|
U_BOOT_DRIVER(cpu_bus) = {
|
|
.name = "cpu_bus",
|
|
.id = UCLASS_SIMPLE_BUS,
|
|
.per_child_platdata_auto_alloc_size = sizeof(struct cpu_platdata),
|
|
};
|
|
|
|
static int uclass_cpu_init(struct uclass *uc)
|
|
{
|
|
struct udevice *dev;
|
|
ofnode node;
|
|
int ret;
|
|
|
|
node = ofnode_path("/cpus");
|
|
if (!ofnode_valid(node))
|
|
return 0;
|
|
|
|
ret = device_bind_driver_to_node(dm_root(), "cpu_bus", "cpus", node,
|
|
&dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
UCLASS_DRIVER(cpu) = {
|
|
.id = UCLASS_CPU,
|
|
.name = "cpu",
|
|
.flags = DM_UC_FLAG_SEQ_ALIAS,
|
|
.init = uclass_cpu_init,
|
|
};
|