mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-12 22:33:18 +00:00
d7a184d4a7
When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be bound before relocation. However due to a bug in the DM core, the flag only takes effect when devices are statically declared via U_BOOT_DEVICE(). This bug has been fixed recently by commit "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt()", but with the fix, it has a side effect that all existing drivers that declared DM_FLAG_PRE_RELOC flag will be bound before relocation now. This may expose potential boot failure on some boards due to insufficient memory during the pre-relocation stage. To mitigate this potential impact, the following changes are implemented: - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver only supports configuration from device tree (OF_CONTROL) - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device is statically declared via U_BOOT_DEVICE() - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for drivers that support both statically declared devices and configuration from device tree Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
88 lines
1.8 KiB
C
88 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2017 Microchip Corporation
|
|
* Wenyou.Yang <wenyou.yang@microchip.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <clk.h>
|
|
#include <dm.h>
|
|
#include <timer.h>
|
|
#include <asm/io.h>
|
|
|
|
#define AT91_PIT_VALUE 0xfffff
|
|
#define AT91_PIT_PITEN BIT(24) /* Timer Enabled */
|
|
|
|
struct atmel_pit_regs {
|
|
u32 mode;
|
|
u32 status;
|
|
u32 value;
|
|
u32 value_image;
|
|
};
|
|
|
|
struct atmel_pit_platdata {
|
|
struct atmel_pit_regs *regs;
|
|
};
|
|
|
|
static int atmel_pit_get_count(struct udevice *dev, u64 *count)
|
|
{
|
|
struct atmel_pit_platdata *plat = dev_get_platdata(dev);
|
|
struct atmel_pit_regs *const regs = plat->regs;
|
|
u32 val = readl(®s->value_image);
|
|
|
|
*count = timer_conv_64(val);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int atmel_pit_probe(struct udevice *dev)
|
|
{
|
|
struct atmel_pit_platdata *plat = dev_get_platdata(dev);
|
|
struct atmel_pit_regs *const regs = plat->regs;
|
|
struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev);
|
|
struct clk clk;
|
|
ulong clk_rate;
|
|
int ret;
|
|
|
|
ret = clk_get_by_index(dev, 0, &clk);
|
|
if (ret)
|
|
return -EINVAL;
|
|
|
|
clk_rate = clk_get_rate(&clk);
|
|
if (!clk_rate)
|
|
return -EINVAL;
|
|
|
|
uc_priv->clock_rate = clk_rate / 16;
|
|
|
|
writel(AT91_PIT_VALUE | AT91_PIT_PITEN, ®s->mode);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int atmel_pit_ofdata_to_platdata(struct udevice *dev)
|
|
{
|
|
struct atmel_pit_platdata *plat = dev_get_platdata(dev);
|
|
|
|
plat->regs = (struct atmel_pit_regs *)devfdt_get_addr_ptr(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct timer_ops atmel_pit_ops = {
|
|
.get_count = atmel_pit_get_count,
|
|
};
|
|
|
|
static const struct udevice_id atmel_pit_ids[] = {
|
|
{ .compatible = "atmel,at91sam9260-pit" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(atmel_pit) = {
|
|
.name = "atmel_pit",
|
|
.id = UCLASS_TIMER,
|
|
.of_match = atmel_pit_ids,
|
|
.ofdata_to_platdata = atmel_pit_ofdata_to_platdata,
|
|
.platdata_auto_alloc_size = sizeof(struct atmel_pit_platdata),
|
|
.probe = atmel_pit_probe,
|
|
.ops = &atmel_pit_ops,
|
|
};
|