mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-06 05:04:26 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
50 lines
1.1 KiB
C
50 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0+ OR X11
|
|
/*
|
|
* Copyright 2019 NXP
|
|
*
|
|
* PCIe Kernel DT fixup of DM U-Boot driver for Freescale PowerPC SoCs
|
|
* Author: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#ifdef CONFIG_OF_BOARD_SETUP
|
|
#include <dm.h>
|
|
#include <fdt_support.h>
|
|
#include <asm/fsl_pci.h>
|
|
#include <linux/libfdt.h>
|
|
#include "pcie_fsl.h"
|
|
|
|
static void ft_fsl_pcie_setup(void *blob, struct fsl_pcie *pcie)
|
|
{
|
|
struct pci_controller *hose = dev_get_uclass_priv(pcie->bus);
|
|
fdt_addr_t regs_addr;
|
|
int off;
|
|
|
|
regs_addr = dev_read_addr(pcie->bus);
|
|
off = fdt_node_offset_by_compat_reg(blob, FSL_PCIE_COMPAT, regs_addr);
|
|
if (off < 0) {
|
|
printf("%s: Fail to find PCIe node@0x%pa\n",
|
|
FSL_PCIE_COMPAT, ®s_addr);
|
|
return;
|
|
}
|
|
|
|
if (!hose || !pcie->enabled)
|
|
fdt_del_node(blob, off);
|
|
else
|
|
fdt_pci_dma_ranges(blob, off, hose);
|
|
}
|
|
|
|
/* Fixup Kernel DT for PCIe */
|
|
void pci_of_setup(void *blob, struct bd_info *bd)
|
|
{
|
|
struct fsl_pcie *pcie;
|
|
|
|
list_for_each_entry(pcie, &fsl_pcie_list, list)
|
|
ft_fsl_pcie_setup(blob, pcie);
|
|
}
|
|
|
|
#else
|
|
void pci_of_setup(void *blob, struct bd_info *bd)
|
|
{
|
|
}
|
|
#endif
|