mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-16 17:58:23 +00:00
b53f6992e9
The DM version of do_reset has been issuing a warm-reset, which (on some platforms keeps GPIOs and other parts of the platform active). This may cause unintended behaviour, as calling do_reset usually indicates a desire to reset the board/platform and not just the CPU. This changes do_reset to always request a COLD reset. Note that programmatic uses can still invoke a WARM reset through reset_cpu() or using sysreset_walk(). Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Reviewed-by: Simon Glass <sjg@chromium.org>
81 lines
1.4 KiB
C
81 lines
1.4 KiB
C
/*
|
|
* Copyright (C) 2015 Google, Inc
|
|
* Written by Simon Glass <sjg@chromium.org>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <sysreset.h>
|
|
#include <dm.h>
|
|
#include <errno.h>
|
|
#include <regmap.h>
|
|
#include <dm/device-internal.h>
|
|
#include <dm/lists.h>
|
|
#include <dm/root.h>
|
|
#include <linux/err.h>
|
|
|
|
int sysreset_request(struct udevice *dev, enum sysreset_t type)
|
|
{
|
|
struct sysreset_ops *ops = sysreset_get_ops(dev);
|
|
|
|
if (!ops->request)
|
|
return -ENOSYS;
|
|
|
|
return ops->request(dev, type);
|
|
}
|
|
|
|
int sysreset_walk(enum sysreset_t type)
|
|
{
|
|
struct udevice *dev;
|
|
int ret = -ENOSYS;
|
|
|
|
while (ret != -EINPROGRESS && type < SYSRESET_COUNT) {
|
|
for (uclass_first_device(UCLASS_SYSRESET, &dev);
|
|
dev;
|
|
uclass_next_device(&dev)) {
|
|
ret = sysreset_request(dev, type);
|
|
if (ret == -EINPROGRESS)
|
|
break;
|
|
}
|
|
type++;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
void sysreset_walk_halt(enum sysreset_t type)
|
|
{
|
|
int ret;
|
|
|
|
ret = sysreset_walk(type);
|
|
|
|
/* Wait for the reset to take effect */
|
|
if (ret == -EINPROGRESS)
|
|
mdelay(100);
|
|
|
|
/* Still no reset? Give up */
|
|
debug("System reset not supported on this platform\n");
|
|
hang();
|
|
}
|
|
|
|
/**
|
|
* reset_cpu() - calls sysreset_walk(SYSRESET_WARM)
|
|
*/
|
|
void reset_cpu(ulong addr)
|
|
{
|
|
sysreset_walk_halt(SYSRESET_WARM);
|
|
}
|
|
|
|
|
|
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
|
|
{
|
|
sysreset_walk_halt(SYSRESET_COLD);
|
|
|
|
return 0;
|
|
}
|
|
|
|
UCLASS_DRIVER(sysreset) = {
|
|
.id = UCLASS_SYSRESET,
|
|
.name = "sysreset",
|
|
};
|