mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-28 15:41:40 +00:00
3ef772230d
When running the efidebug capsule disk-update command, the efi_fmp_raw
protocol installation fails with 2 (EFI_INVALID_PARAMETER) as below.
This is because the code passes efi_root instead of the handle local var.
=> efidebug capsule disk-update
EFI: Call: efi_install_multiple_protocol_interfaces( &handle, &efi_guid_firmware_management_protocol, &efi_fmp_fit, NULL)
EFI: Entry efi_install_multiple_protocol_interfaces(00000000fbaf5988)
EFI: Call: efi_install_protocol_interface( handle, protocol, EFI_NATIVE_INTERFACE, protocol_interface)
EFI: Entry efi_install_protocol_interface(00000000fbaf5988, 86c77a67-0b97-4633-a187-49104d0685c7, 0, 00000000fbfa6ee8)
EFI: new handle 00000000fbb37520
EFI: Exit: efi_install_protocol_interface: 0
EFI: 0 returned by efi_install_protocol_interface( handle, protocol, EFI_NATIVE_INTERFACE, protocol_interface)
EFI: Exit: efi_install_multiple_protocol_interfaces: 0
EFI: 0 returned by efi_install_multiple_protocol_interfaces( &handle, &efi_guid_firmware_management_protocol, &efi_fmp_fit, NULL)
EFI: Call: efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL)
EFI: Entry efi_install_multiple_protocol_interfaces(00000000fbfec648)
EFI: Call: efi_install_protocol_interface( handle, protocol, EFI_NATIVE_INTERFACE, protocol_interface)
EFI: Entry efi_install_protocol_interface(00000000fbfec648, 86c77a67-0b97-4633-a187-49104d0685c7, 0, 00000000fbfa6f18)
EFI: handle 00000000fbaf8520
EFI: Exit: efi_install_protocol_interface: 2
EFI: 2 returned by efi_install_protocol_interface( handle, protocol, EFI_NATIVE_INTERFACE, protocol_interface)
EFI: Exit: efi_install_multiple_protocol_interfaces: 2
EFI: 2 returned by efi_install_multiple_protocol_interfaces( &efi_root, &efi_guid_firmware_management_protocol, &efi_fmp_raw, NULL)
Command failed, result=1
To fix this issue, pass the handle local var which is set NULL right
before installing efi_fmp_raw as same as the installing efi_fmp_fit.
(In both cases, the local reference to the handle will be just discarded)
Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| efi_acpi.c | ||
| efi_bootmgr.c | ||
| efi_boottime.c | ||
| efi_capsule.c | ||
| efi_console.c | ||
| efi_device_path.c | ||
| efi_device_path_to_text.c | ||
| efi_device_path_utilities.c | ||
| efi_disk.c | ||
| efi_dt_fixup.c | ||
| efi_esrt.c | ||
| efi_file.c | ||
| efi_firmware.c | ||
| efi_freestanding.c | ||
| efi_gop.c | ||
| efi_helper.c | ||
| efi_hii.c | ||
| efi_hii_config.c | ||
| efi_image_loader.c | ||
| efi_load_initrd.c | ||
| efi_load_options.c | ||
| efi_memory.c | ||
| efi_net.c | ||
| efi_rng.c | ||
| efi_root_node.c | ||
| efi_runtime.c | ||
| efi_setup.c | ||
| efi_signature.c | ||
| efi_smbios.c | ||
| efi_string.c | ||
| efi_tcg2.c | ||
| efi_unicode_collation.c | ||
| efi_var_common.c | ||
| efi_var_file.c | ||
| efi_var_mem.c | ||
| efi_var_seed.S | ||
| efi_variable.c | ||
| efi_variable_tee.c | ||
| efi_watchdog.c | ||
| helloworld.c | ||
| Kconfig | ||
| Makefile | ||