u-boot/drivers/tpm
Miquel Raynal 46703cd9f3 tpm: sandbox: fix wrong assignment with a simplification
The recv variable in sandbox_tpm2_fill_buf() is a pointer on a pointer
of a char array. It means accessing *recv is the char array pointer
itself while **recv is the first character of that array. There is no
need for such indirection here, so simplify the code.

Simplifying things will make the last assignment right: "*recv = NULL"
is now correct. The issue has been found by the following Coverity
Scan report:

    CID 183371:  Incorrect expression  (UNUSED_VALUE)
    Assigning value "4UL" to "*recv" here, but that stored value is overwritten before it can be used.
    232             *recv += sizeof(rc);
    233
    234             /* Add trailing \0 */
    235             *recv = NULL;

While at simplifying things, use '\0' instead of NULL when adding an
empty char at the end of the buffer.

Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
2018-08-13 14:04:04 -04:00
..
Kconfig tpm: make TPM_V2 be compiled by default 2018-07-28 11:58:09 -04:00
Makefile tpm: add a Sandbox TPMv2.x driver 2018-05-25 20:13:00 -04:00
tpm-uclass.c tpm: allow TPM v1 and v2 to be compiled at the same time 2018-07-28 11:57:38 -04:00
tpm2_tis_sandbox.c tpm: sandbox: fix wrong assignment with a simplification 2018-08-13 14:04:04 -04:00
tpm2_tis_spi.c tpm: allow TPM v1 and v2 to be compiled at the same time 2018-07-28 11:57:38 -04:00
tpm_atmel_twi.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00
tpm_internal.h SPDX: Convert all of our single license tags to Linux Kernel style 2018-05-07 09:34:12 -04:00
tpm_tis.h tpm: add Revision ID field in the chip structure 2018-05-25 08:12:40 -04:00
tpm_tis_infineon.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00
tpm_tis_lpc.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00
tpm_tis_sandbox.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00
tpm_tis_st33zp24_i2c.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00
tpm_tis_st33zp24_spi.c tpm: disociate TPMv1.x specific and generic code 2018-05-25 20:12:55 -04:00