mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-26 06:30:39 +00:00
9b643e312d
U-Boot widely uses error() as a bit noisier variant of printf(). This macro causes name conflict with the following line in include/linux/compiler-gcc.h: # define __compiletime_error(message) __attribute__((error(message))) This prevents us from using __compiletime_error(), and makes it difficult to fully sync BUILD_BUG macros with Linux. (Notice Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().) Let's convert error() into now treewide-available pr_err(). Done with the help of Coccinelle, excluing tools/ directory. The semantic patch I used is as follows: // <smpl> @@@@ -error +pr_err (...) // </smpl> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Simon Glass <sjg@chromium.org> [trini: Re-run Coccinelle] Signed-off-by: Tom Rini <trini@konsulko.com>
65 lines
1.4 KiB
C
65 lines
1.4 KiB
C
/*
|
|
* (C) Copyright 2015
|
|
* Lukasz Majewski <l.majewski@majess.pl>
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0+
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <malloc.h>
|
|
#include <errno.h>
|
|
#include <dfu.h>
|
|
|
|
int dfu_tftp_write(char *dfu_entity_name, unsigned int addr, unsigned int len,
|
|
char *interface, char *devstring)
|
|
{
|
|
char *s, *sb;
|
|
int alt_setting_num, ret;
|
|
struct dfu_entity *dfu;
|
|
|
|
debug("%s: name: %s addr: 0x%x len: %d device: %s:%s\n", __func__,
|
|
dfu_entity_name, addr, len, interface, devstring);
|
|
|
|
ret = dfu_init_env_entities(interface, devstring);
|
|
if (ret)
|
|
goto done;
|
|
|
|
/*
|
|
* We need to copy name pointed by *dfu_entity_name since this text
|
|
* is the integral part of the FDT image.
|
|
* Any implicit modification (i.e. done by strsep()) will corrupt
|
|
* the FDT image and prevent other images to be stored.
|
|
*/
|
|
s = strdup(dfu_entity_name);
|
|
sb = s;
|
|
if (!s) {
|
|
ret = -ENOMEM;
|
|
goto done;
|
|
}
|
|
|
|
strsep(&s, "@");
|
|
debug("%s: image name: %s strlen: %d\n", __func__, sb, strlen(sb));
|
|
|
|
alt_setting_num = dfu_get_alt(sb);
|
|
free(sb);
|
|
if (alt_setting_num < 0) {
|
|
pr_err("Alt setting [%d] to write not found!",
|
|
alt_setting_num);
|
|
ret = -ENODEV;
|
|
goto done;
|
|
}
|
|
|
|
dfu = dfu_get_entity(alt_setting_num);
|
|
if (!dfu) {
|
|
pr_err("DFU entity for alt: %d not found!", alt_setting_num);
|
|
ret = -ENODEV;
|
|
goto done;
|
|
}
|
|
|
|
ret = dfu_write_from_mem_addr(dfu, (void *)addr, len);
|
|
|
|
done:
|
|
dfu_free_entities();
|
|
|
|
return ret;
|
|
}
|