mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-11 23:47:24 +00:00
d657766819
Local variable out.name lives on the stack and therefore cannot
be returned directly. Move the strdup() call into the function.
(Coverity 352460)
Fixes: 7c33f78983
("clk: scmi: register scmi clocks with CCF")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Sean Anderson <seanga2@gmail.com>
190 lines
3.8 KiB
C
190 lines
3.8 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2019-2020 Linaro Limited
|
|
*/
|
|
|
|
#define LOG_CATEGORY UCLASS_CLK
|
|
|
|
#include <common.h>
|
|
#include <clk-uclass.h>
|
|
#include <dm.h>
|
|
#include <scmi_agent.h>
|
|
#include <scmi_protocols.h>
|
|
#include <asm/types.h>
|
|
#include <linux/clk-provider.h>
|
|
|
|
static int scmi_clk_get_num_clock(struct udevice *dev, size_t *num_clocks)
|
|
{
|
|
struct scmi_clk_protocol_attr_out out;
|
|
struct scmi_msg msg = {
|
|
.protocol_id = SCMI_PROTOCOL_ID_CLOCK,
|
|
.message_id = SCMI_PROTOCOL_ATTRIBUTES,
|
|
.out_msg = (u8 *)&out,
|
|
.out_msg_sz = sizeof(out),
|
|
};
|
|
int ret;
|
|
|
|
ret = devm_scmi_process_msg(dev, &msg);
|
|
if (ret)
|
|
return ret;
|
|
|
|
*num_clocks = out.attributes & SCMI_CLK_PROTO_ATTR_COUNT_MASK;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int scmi_clk_get_attibute(struct udevice *dev, int clkid, char **name)
|
|
{
|
|
struct scmi_clk_attribute_in in = {
|
|
.clock_id = clkid,
|
|
};
|
|
struct scmi_clk_attribute_out out;
|
|
struct scmi_msg msg = {
|
|
.protocol_id = SCMI_PROTOCOL_ID_CLOCK,
|
|
.message_id = SCMI_CLOCK_ATTRIBUTES,
|
|
.in_msg = (u8 *)&in,
|
|
.in_msg_sz = sizeof(in),
|
|
.out_msg = (u8 *)&out,
|
|
.out_msg_sz = sizeof(out),
|
|
};
|
|
int ret;
|
|
|
|
ret = devm_scmi_process_msg(dev, &msg);
|
|
if (ret)
|
|
return ret;
|
|
|
|
*name = strdup(out.clock_name);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int scmi_clk_gate(struct clk *clk, int enable)
|
|
{
|
|
struct scmi_clk_state_in in = {
|
|
.clock_id = clk->id,
|
|
.attributes = enable,
|
|
};
|
|
struct scmi_clk_state_out out;
|
|
struct scmi_msg msg = SCMI_MSG_IN(SCMI_PROTOCOL_ID_CLOCK,
|
|
SCMI_CLOCK_CONFIG_SET,
|
|
in, out);
|
|
int ret;
|
|
|
|
ret = devm_scmi_process_msg(clk->dev, &msg);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return scmi_to_linux_errno(out.status);
|
|
}
|
|
|
|
static int scmi_clk_enable(struct clk *clk)
|
|
{
|
|
return scmi_clk_gate(clk, 1);
|
|
}
|
|
|
|
static int scmi_clk_disable(struct clk *clk)
|
|
{
|
|
return scmi_clk_gate(clk, 0);
|
|
}
|
|
|
|
static ulong scmi_clk_get_rate(struct clk *clk)
|
|
{
|
|
struct scmi_clk_rate_get_in in = {
|
|
.clock_id = clk->id,
|
|
};
|
|
struct scmi_clk_rate_get_out out;
|
|
struct scmi_msg msg = SCMI_MSG_IN(SCMI_PROTOCOL_ID_CLOCK,
|
|
SCMI_CLOCK_RATE_GET,
|
|
in, out);
|
|
int ret;
|
|
|
|
ret = devm_scmi_process_msg(clk->dev, &msg);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = scmi_to_linux_errno(out.status);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return (ulong)(((u64)out.rate_msb << 32) | out.rate_lsb);
|
|
}
|
|
|
|
static ulong scmi_clk_set_rate(struct clk *clk, ulong rate)
|
|
{
|
|
struct scmi_clk_rate_set_in in = {
|
|
.clock_id = clk->id,
|
|
.flags = SCMI_CLK_RATE_ROUND_CLOSEST,
|
|
.rate_lsb = (u32)rate,
|
|
.rate_msb = (u32)((u64)rate >> 32),
|
|
};
|
|
struct scmi_clk_rate_set_out out;
|
|
struct scmi_msg msg = SCMI_MSG_IN(SCMI_PROTOCOL_ID_CLOCK,
|
|
SCMI_CLOCK_RATE_SET,
|
|
in, out);
|
|
int ret;
|
|
|
|
ret = devm_scmi_process_msg(clk->dev, &msg);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = scmi_to_linux_errno(out.status);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return scmi_clk_get_rate(clk);
|
|
}
|
|
|
|
static int scmi_clk_probe(struct udevice *dev)
|
|
{
|
|
struct clk *clk;
|
|
size_t num_clocks, i;
|
|
int ret;
|
|
|
|
if (!CONFIG_IS_ENABLED(CLK_CCF))
|
|
return 0;
|
|
|
|
/* register CCF children: CLK UCLASS, no probed again */
|
|
if (device_get_uclass_id(dev->parent) == UCLASS_CLK)
|
|
return 0;
|
|
|
|
ret = scmi_clk_get_num_clock(dev, &num_clocks);
|
|
if (ret)
|
|
return ret;
|
|
|
|
for (i = 0; i < num_clocks; i++) {
|
|
char *clock_name;
|
|
|
|
if (!scmi_clk_get_attibute(dev, i, &clock_name)) {
|
|
clk = kzalloc(sizeof(*clk), GFP_KERNEL);
|
|
if (!clk || !clock_name)
|
|
ret = -ENOMEM;
|
|
else
|
|
ret = clk_register(clk, dev->driver->name,
|
|
clock_name, dev->name);
|
|
|
|
if (ret) {
|
|
free(clk);
|
|
free(clock_name);
|
|
return ret;
|
|
}
|
|
|
|
clk_dm(i, clk);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct clk_ops scmi_clk_ops = {
|
|
.enable = scmi_clk_enable,
|
|
.disable = scmi_clk_disable,
|
|
.get_rate = scmi_clk_get_rate,
|
|
.set_rate = scmi_clk_set_rate,
|
|
};
|
|
|
|
U_BOOT_DRIVER(scmi_clock) = {
|
|
.name = "scmi_clk",
|
|
.id = UCLASS_CLK,
|
|
.ops = &scmi_clk_ops,
|
|
.probe = &scmi_clk_probe,
|
|
};
|