mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-03 01:50:25 +00:00
ea9619aed6
The stm_is_locked_sr() function is picked from Linux kernel. For reason unknown, the 64bit data types used by the function and present in Linux were replaced with 32bit unsigned ones, which causes trouble. The testcase performed was done using ST M25P80 chip. The command used was: => sf protect unlock 0 0x10000 The call chain starts in stm_unlock(), which calls stm_is_locked_sr() with negative ofs argument. This works fine in Linux, where the "ofs" is loff_t, which is signed long long, while this fails in U-Boot, where "ofs" is u32 (unsigned int). Because of this signedness problem, the expression past the return statement to be incorrectly evaluated to 1, which in turn propagates back to stm_unlock() and results in -EINVAL. The correction is very simple, just use the correctly sized data types with correct signedness in the function to make it work as intended. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Simon Glass <sjg@chromium.org> Reviewed-by: Jagan Teki <jteki@openedev.com> |
||
|---|---|---|
| .. | ||
| fsl_espi_spl.c | ||
| Kconfig | ||
| Makefile | ||
| sandbox.c | ||
| sf-uclass.c | ||
| sf.c | ||
| sf_dataflash.c | ||
| sf_internal.h | ||
| sf_mtd.c | ||
| sf_params.c | ||
| sf_probe.c | ||
| spi_flash.c | ||
| spi_spl_load.c | ||