Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-18 10:48:51 +00:00
Code Issues Projects Releases Packages Wiki Activity
u-boot/board
History
Harald Seiler 10b86ef9b3 board: ns3: Remove superfluous reset logic 
The current implementation of reset_cpu() in the ns3 board code does not
archieve what it is supposed to (according to the comments), due to
a number of reasons:

 1. The argument to reset_cpu() is _not_ actually passed from the
    `reset` command, but is set to 0 in all call-sites (in this
    specific case, see arch/arm/lib/reset.c).  Thus, performing
    different kinds of resets based on its value will not work as
    expected.

 2. Contrary to its documentation, the passed argument is not
    interpreted, but a static `L3_RESET` define is used.  The other
    comment properly notes that this will always perform a L3 reset,
    though.

 3. The "parsing" of the static `L3_RESET` value is not even using the
    upper and lower nibble as stated in the comment, but uses the last
    two decimal digits of the value.

This is currently one of the only implementations left in U-Boot, which
make "use" of the value passed to reset_cpu().  As this is done under
false assumption (the value does not have any meaning anymore), it makes
sense to bring it into line with the rest and start ignoring the
parameter.

This is a preparation for removal of the reset_cpu() parameter across
the entire tree in a later patch.

Fixes: b5a152e7ca ("board: ns3: default reset type to L3")
Cc: Bharat Gooty <bharat.gooty@broadcom.com>
Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
2021-03-02 11:24:29 -05:00
..
abilis/tb100 treewide: convert bd_t to struct bd_info by coccinelle 2020-07-17 09:30:13 -04:00
advantech common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
alliedtelesis ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
altera Merge branch '2021.04-rc' of https://github.com/lftan/u-boot 2021-01-15 07:55:11 -05:00
amarula/vyasa-rk3288 common: Move serial functions out of common.h 2019-12-02 18:23:11 -05:00
amazon/kc1 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
amlogic Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
AndesTech Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
Arcturus/ucp1020 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
aries/mcvevk
aristainetos common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
armadeus common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
armltd common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
aspeed configs: aspeed: Add defconfig for AST2600 EVB 2021-01-18 15:23:06 -05:00
astro/mcf5373l common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
atmark-techno/armadillo-800eva common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
atmel common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
avionic-design common: Drop log.h from common header 2020-05-18 21:19:18 -04:00
bachmann/ot1200 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
barco common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
beacon Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
beckhoff/mx53cx9020 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
birdland/bav335x arm: Remove bav335x board 2020-07-09 20:58:05 +05:30
bitmain/antminer_s9 xilinx: Introduce board_late_init_xilinx() 2020-04-27 13:57:17 +02:00
bluewater common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
bosch common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
boundary/nitrogen6x common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
broadcom board: ns3: Remove superfluous reset logic 2021-03-02 11:24:29 -05:00
bticino/mamoj common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
buffalo/lsxl common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
BuR common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
BuS/eb_cpu5282 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cadence/xtfpga dm: Rename U_BOOT_DEVICE() to U_BOOT_DRVINFO() 2021-01-05 12:26:35 -07:00
calao/usb_a9263 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
CarMediaLab/flea3 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cavium/thunderx common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ccv/xpress common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cei/cei-tk1-som
chipspark/popmetal_rk3288 common: Move some board functions out of common.h 2019-12-02 18:25:21 -05:00
cirrus/edb93xx common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cloudengines/pogo_e02 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cobra5272 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
compal/paz00 common: Drop log.h from common header 2020-05-18 21:19:18 -04:00
compulab common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
comtrend
congatec common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
coreboot common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
corscience/tricorder common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cortina common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
creative/xfi3 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
cssi common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
CZ.NIC ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
d-link/dns325 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
davinci/da8xxevm common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
devboards/dbm-soc1
dfi x86: dfi: dfi-bt700: Remove dead code 2020-09-01 13:38:39 +08:00
dhelectronics common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ea/mx7ulp_com common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ebv/socrates
eets/pdu001 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
efi x86: efi: efi-x86_payload: Remove dead code 2020-09-01 13:38:39 +08:00
egnite/ethernut5 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
el/el6x common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
elgin/elgin_rv1108 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
embest/mx6boards common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
emulation common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
engicam common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
esd common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
firefly common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
freescale ppc: Remove MPC8569MDS board 2021-02-25 11:59:54 -05:00
friendlyarm dm: i2c: use CONFIG_IS_ENABLED macro for DM_I2C/DM_I2C_GPIO 2021-02-21 06:08:00 +01:00
gardena common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
gateworks/gw_ventana common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
gdsys ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
ge common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
geekbuying/geekbox rockchip: rk3368: Migrate to use common board file 2019-07-29 10:27:48 +08:00
google Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
grinn common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
hardkernel/odroid_go2 rockchip: board: add Hardkernel Odroid Go2 board 2020-07-22 20:21:23 +08:00
highbank common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
hisilicon common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
huawei/hg556a
ids/ids8313 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
imgtec common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
intel Merge branch '2021.04-rc' of https://github.com/lftan/u-boot 2021-01-15 07:55:11 -05:00
inversepath/usbarmory common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
iomega/iconnect common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
is1
isee common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
k+p common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
keymile dm: i2c: use CONFIG_IS_ENABLED macro for DM_I2C/DM_I2C_GPIO 2021-02-21 06:08:00 +01:00
kmc/kzm9g common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
kobol/helios4 ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
kontron/sl28 Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
kosagi/novena common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
l+g/vinco common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
LaCie common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
laird common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
lego/ev3 Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
lg/sniper common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
liebherr common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
logicpd common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
Marvell ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
maxbcm common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
mediatek common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
menlo/m53menlo common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
microchip common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
mikrotik/crs3xx-98dx3236 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
mini-box/picosam9g45 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
mpc8308_p1m common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
mqmaker/miqi_rk3288
mscc common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
myir/mys_6ulx common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
netgear common: Drop linux/bitops.h from common header 2020-05-18 21:19:23 -04:00
nokia/rx51 Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
novtech/meerkat96 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
nvidia dm: Rename DM_GET_DRIVER() to DM_DRIVER_GET() 2021-01-05 12:26:35 -07:00
olimex/mx23_olinuxino common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
opalkelly/zynq arm: zynq: Remove low level UART setting 2020-01-14 09:05:53 +01:00
phytec common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
phytium/durian common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
pine64 rockchip: Add initial support for the Pinebook Pro laptop from Pine64. 2020-05-31 22:22:07 +08:00
ppcag/bg0900 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
qca common: Drop init.h from common header 2020-05-18 17:33:33 -04:00
qemu-mips common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
qualcomm common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
radxa
raidsonic/ib62x0 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
raspberrypi/rpi rpi: Add identifier for the new CM4 2021-02-18 11:56:25 +01:00
renesas Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
rockchip common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ronetix common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sagem/f@st1704
samsung samsung: origen: change maintainer 2021-02-23 15:43:27 +09:00
sandbox common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sandisk/sansa_fuze_plus common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sbc8349 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sbc8548 treewide: convert bd_t to struct bd_info by coccinelle 2020-07-17 09:30:13 -04:00
sbc8641d common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
schulercontrol/sc_sps_1 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
Seagate common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
seco common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
seeed/linkit-smart-7688 common: Drop linux/bitops.h from common header 2020-05-18 21:19:23 -04:00
sfr/nb4_ser
siemens common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sifive/fu540 dm: Rename DM_GET_DRIVER() to DM_DRIVER_GET() 2021-01-05 12:26:35 -07:00
sipeed/maix riscv: Add support for SPI on Kendryte K210 2021-01-18 11:06:26 +08:00
socrates video: remove unused include/mb862xx.h 2021-02-19 22:36:56 +01:00
softing common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
solidrun ddr: marvell: a38x: add support for twin-die combined memory device 2021-02-26 10:22:29 +01:00
somlabs/visionsom-6ull common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
spear treewide: convert bd_t to struct bd_info by coccinelle 2020-07-17 09:30:13 -04:00
sr1500 common: Drop linux/delay.h from common header 2020-05-18 21:19:23 -04:00
st Correct U-Boot upstream repository 2021-02-28 13:57:30 -05:00
ste/stemmy common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sunxi dm: i2c: use CONFIG_IS_ENABLED macro for DM_I2C/DM_I2C_GPIO 2021-02-21 06:08:00 +01:00
Synology common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
synopsys common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
sysam common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
syteco/zmx25 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
tbs/tbs2910 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
tcl/sl50 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
technexion common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
technologic common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
terasic
theadorable Merge branch '2021-02-02-drop-asm_global_data-when-unused' 2021-02-15 10:16:45 -05:00
theobroma-systems rockchip: puma: drop special handling of usb host regulator 2020-06-07 18:57:16 +08:00
ti Correct U-Boot upstream repository 2021-02-28 13:57:30 -05:00
timll common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
topic/zynq board: topic-miami: Set FCLK1 to 150MHz 2020-06-24 13:11:08 +02:00
toradex common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
tplink/wdr4300 common: Drop linux/bitops.h from common header 2020-05-18 21:19:23 -04:00
tqc common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
udoo common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
vamrs/rock960_rk3399 rockchip: Remove ARCH= references from documentation 2020-06-02 17:27:04 -04:00
variscite/dart_6ul common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
varisys common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ve8313 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
vocore/vocore2 mips: Add support for SoM "VoCore2". 2020-04-27 20:30:14 +02:00
vscom/baltos common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
wandboard dm: i2c: use CONFIG_IS_ENABLED macro for DM_I2C/DM_I2C_GPIO 2021-02-21 06:08:00 +01:00
warp common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
warp7 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
work-microwave/work_92105 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
xen/xenguest_arm64 common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
xes common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
xilinx Correct U-Boot upstream repository 2021-02-28 13:57:30 -05:00
zyxel/nsa310s common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00