mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-05 11:00:15 +00:00
34b1a510e8
commit1b898ffc04
("gpio: dwapb_gpio: convert to livetree") introduced a bug in that dev->node of the gpio chip was accidentally set to the of_node of its bank subnode. What it meant to do was assign subdev->node, not dev->node. While this doesn't affect too many use cases, iterating over the gpio chip's properties doesn't work any more after that, so fix this. Fixes: commit1b898ffc04
("gpio: dwapb_gpio: convert to livetree") Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
224 lines
5 KiB
C
224 lines
5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* (C) Copyright 2015 Marek Vasut <marex@denx.de>
|
|
*
|
|
* DesignWare APB GPIO driver
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <malloc.h>
|
|
#include <asm/arch/gpio.h>
|
|
#include <asm/gpio.h>
|
|
#include <asm/io.h>
|
|
#include <dm.h>
|
|
#include <dm/device-internal.h>
|
|
#include <dm/lists.h>
|
|
#include <dm/root.h>
|
|
#include <errno.h>
|
|
#include <reset.h>
|
|
|
|
#define GPIO_SWPORT_DR(p) (0x00 + (p) * 0xc)
|
|
#define GPIO_SWPORT_DDR(p) (0x04 + (p) * 0xc)
|
|
#define GPIO_INTEN 0x30
|
|
#define GPIO_INTMASK 0x34
|
|
#define GPIO_INTTYPE_LEVEL 0x38
|
|
#define GPIO_INT_POLARITY 0x3c
|
|
#define GPIO_INTSTATUS 0x40
|
|
#define GPIO_PORTA_DEBOUNCE 0x48
|
|
#define GPIO_PORTA_EOI 0x4c
|
|
#define GPIO_EXT_PORT(p) (0x50 + (p) * 4)
|
|
|
|
struct gpio_dwapb_priv {
|
|
struct reset_ctl_bulk resets;
|
|
};
|
|
|
|
struct gpio_dwapb_platdata {
|
|
const char *name;
|
|
int bank;
|
|
int pins;
|
|
fdt_addr_t base;
|
|
};
|
|
|
|
static int dwapb_gpio_direction_input(struct udevice *dev, unsigned pin)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
|
|
clrbits_le32(plat->base + GPIO_SWPORT_DDR(plat->bank), 1 << pin);
|
|
return 0;
|
|
}
|
|
|
|
static int dwapb_gpio_direction_output(struct udevice *dev, unsigned pin,
|
|
int val)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
|
|
setbits_le32(plat->base + GPIO_SWPORT_DDR(plat->bank), 1 << pin);
|
|
|
|
if (val)
|
|
setbits_le32(plat->base + GPIO_SWPORT_DR(plat->bank), 1 << pin);
|
|
else
|
|
clrbits_le32(plat->base + GPIO_SWPORT_DR(plat->bank), 1 << pin);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int dwapb_gpio_get_value(struct udevice *dev, unsigned pin)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
return !!(readl(plat->base + GPIO_EXT_PORT(plat->bank)) & (1 << pin));
|
|
}
|
|
|
|
|
|
static int dwapb_gpio_set_value(struct udevice *dev, unsigned pin, int val)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
|
|
if (val)
|
|
setbits_le32(plat->base + GPIO_SWPORT_DR(plat->bank), 1 << pin);
|
|
else
|
|
clrbits_le32(plat->base + GPIO_SWPORT_DR(plat->bank), 1 << pin);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int dwapb_gpio_get_function(struct udevice *dev, unsigned offset)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
u32 gpio;
|
|
|
|
gpio = readl(plat->base + GPIO_SWPORT_DDR(plat->bank));
|
|
|
|
if (gpio & BIT(offset))
|
|
return GPIOF_OUTPUT;
|
|
else
|
|
return GPIOF_INPUT;
|
|
}
|
|
|
|
static const struct dm_gpio_ops gpio_dwapb_ops = {
|
|
.direction_input = dwapb_gpio_direction_input,
|
|
.direction_output = dwapb_gpio_direction_output,
|
|
.get_value = dwapb_gpio_get_value,
|
|
.set_value = dwapb_gpio_set_value,
|
|
.get_function = dwapb_gpio_get_function,
|
|
};
|
|
|
|
static int gpio_dwapb_reset(struct udevice *dev)
|
|
{
|
|
int ret;
|
|
struct gpio_dwapb_priv *priv = dev_get_priv(dev);
|
|
|
|
ret = reset_get_bulk(dev, &priv->resets);
|
|
if (ret) {
|
|
/* Return 0 if error due to !CONFIG_DM_RESET and reset
|
|
* DT property is not present.
|
|
*/
|
|
if (ret == -ENOENT || ret == -ENOTSUPP)
|
|
return 0;
|
|
|
|
dev_warn(dev, "Can't get reset: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = reset_deassert_bulk(&priv->resets);
|
|
if (ret) {
|
|
reset_release_bulk(&priv->resets);
|
|
dev_err(dev, "Failed to reset: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int gpio_dwapb_probe(struct udevice *dev)
|
|
{
|
|
struct gpio_dev_priv *priv = dev_get_uclass_priv(dev);
|
|
struct gpio_dwapb_platdata *plat = dev->platdata;
|
|
|
|
if (!plat) {
|
|
/* Reset on parent device only */
|
|
return gpio_dwapb_reset(dev);
|
|
}
|
|
|
|
priv->gpio_count = plat->pins;
|
|
priv->bank_name = plat->name;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int gpio_dwapb_bind(struct udevice *dev)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
struct udevice *subdev;
|
|
fdt_addr_t base;
|
|
int ret, bank = 0;
|
|
ofnode node;
|
|
|
|
/* If this is a child device, there is nothing to do here */
|
|
if (plat)
|
|
return 0;
|
|
|
|
base = dev_read_addr(dev);
|
|
if (base == FDT_ADDR_T_NONE) {
|
|
debug("Can't get the GPIO register base address\n");
|
|
return -ENXIO;
|
|
}
|
|
|
|
for (node = dev_read_first_subnode(dev); ofnode_valid(node);
|
|
node = dev_read_next_subnode(node)) {
|
|
if (!ofnode_read_bool(node, "gpio-controller"))
|
|
continue;
|
|
|
|
plat = devm_kcalloc(dev, 1, sizeof(*plat), GFP_KERNEL);
|
|
if (!plat)
|
|
return -ENOMEM;
|
|
|
|
plat->base = base;
|
|
plat->bank = bank;
|
|
plat->pins = ofnode_read_u32_default(node, "snps,nr-gpios", 0);
|
|
|
|
if (ofnode_read_string_index(node, "bank-name", 0,
|
|
&plat->name)) {
|
|
/*
|
|
* Fall back to node name. This means accessing pins
|
|
* via bank name won't work.
|
|
*/
|
|
plat->name = ofnode_get_name(node);
|
|
}
|
|
|
|
ret = device_bind_ofnode(dev, dev->driver, plat->name,
|
|
plat, node, &subdev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
bank++;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int gpio_dwapb_remove(struct udevice *dev)
|
|
{
|
|
struct gpio_dwapb_platdata *plat = dev_get_platdata(dev);
|
|
struct gpio_dwapb_priv *priv = dev_get_priv(dev);
|
|
|
|
if (!plat && priv)
|
|
return reset_release_bulk(&priv->resets);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct udevice_id gpio_dwapb_ids[] = {
|
|
{ .compatible = "snps,dw-apb-gpio" },
|
|
{ }
|
|
};
|
|
|
|
U_BOOT_DRIVER(gpio_dwapb) = {
|
|
.name = "gpio-dwapb",
|
|
.id = UCLASS_GPIO,
|
|
.of_match = gpio_dwapb_ids,
|
|
.ops = &gpio_dwapb_ops,
|
|
.bind = gpio_dwapb_bind,
|
|
.probe = gpio_dwapb_probe,
|
|
.remove = gpio_dwapb_remove,
|
|
.priv_auto_alloc_size = sizeof(struct gpio_dwapb_priv),
|
|
};
|