mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-11 22:03:15 +00:00
306f527eff
It was found that the L2 cache timings that we had before could cause
freezes and hangs. We should make things more robust with better
timings. Currently the production ChromeOS kernel applies these
timings, but it's nice to fixup firmware too (and upstream probably
won't take our kernel hacks).
This also provides a big cleanup of the L2 cache init code avoiding
some duplication. The way things used to work:
* low_power_start() was installed by the SPL (both at boot and resume
time) and left resident in iRAM for the kernel to use when bringing
up additional CPUs. It used configure_l2_ctlr() and
configure_l2_actlr() when it detected it was on an A15. This was
needed (despite the L2 cache registers being shared among all A15s)
because we might have been the first man in after the whole A15
cluster was shutdown.
* secondary_cores_configure() was called on at boot time and at resume
time. Strangely this called configure_l2_ctlr() but not
configure_l2_actlr() which was almost certainly wrong. Given that
we'll call both (see next bullet) later in the boot process it
didn't matter for normal boot, but I guess this is how L2 cache
settings got set on 5420/5800 (but not 5250?) at resume time.
* exynos5_set_l2cache_params() was called as part of cache enablement.
This should happen at boot time (normally in the SPL except for USB
boot where it happens in main U-Boot).
Note that the old code wasn't setting ECC/parity in the cache
enablement code but we happened to get it anyway because we'd call
secondary_cores_configure() at boot time. For resume time we'd get it
anyway when the 2nd A15 core came up.
Let's make this a whole lot simpler. Now we always set these
parameters in the same place for all boots and use the same code for
setting up secondary CPUs.
Intended net effects of this change (other than cleanup):
* Timings go from before:
data: 0 cycle setup, 3 cycles (0x2) latency
tag: 0 cycle setup, 3 cycles (0x2) latency
after:
data: 1 cycle setup, 4 cycles (0x3) latency
tag: 1 cycle setup, 4 cycles (0x3) latency
* L2ACTLR is properly initted on 5420/5800 in all cases.
One note is that we're still relying on luck to keep low_power_start()
working. The compiler is being nice and not storing anything on the
stack.
Another note is that on its own this patch won't help to fix cache
settings in an RW U-Boot update where we still have the RO SPL. The
plan for that is:
* Have RW U-Boot re-init the cache right before calling the kernel
(after it has turned the L2 cache off). This is why the functions
are in a header file instead of lowlevel_init.c.
* Have the kernel save the L2 cache settings of the boot CPU and apply
them to all other CPUs. We get a little lucky here because the old
code was using "|=" to modify the registers and all of the bits that
it's setting are also present in the new settings (!). That means
that when the 2nd CPU in the A15 cluster comes up it doesn't
actually mess up the settings of the 1st CPU in the A15 cluster. An
alternative option is to have the kernel write its own
low_power_start() code.
Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Akshay Saraswat <akshay.s@samsung.com>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
107 lines
2.7 KiB
C
107 lines
2.7 KiB
C
/*
|
|
* Common APIs for EXYNOS based board
|
|
*
|
|
* Copyright (C) 2013 Samsung Electronics
|
|
* Rajeshwari Shinde <rajeshwari.s@samsung.com>
|
|
*
|
|
* See file CREDITS for list of people who contributed to this
|
|
* project.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston,
|
|
* MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <asm/arch/system.h>
|
|
|
|
#define DMC_OFFSET 0x10000
|
|
|
|
/*
|
|
* Memory initialization
|
|
*
|
|
* @param reset Reset PHY during initialization.
|
|
*/
|
|
void mem_ctrl_init(int reset);
|
|
|
|
/* System Clock initialization */
|
|
void system_clock_init(void);
|
|
|
|
/*
|
|
* Init subsystems according to the reset status
|
|
*
|
|
* @return 0 for a normal boot, non-zero for a resume
|
|
*/
|
|
int do_lowlevel_init(void);
|
|
|
|
void sdelay(unsigned long);
|
|
|
|
enum l2_cache_params {
|
|
CACHE_DATA_RAM_LATENCY_2_CYCLES = (2 << 0),
|
|
CACHE_DATA_RAM_LATENCY_3_CYCLES = (3 << 0),
|
|
CACHE_DISABLE_CLEAN_EVICT = (1 << 3),
|
|
CACHE_DATA_RAM_SETUP = (1 << 5),
|
|
CACHE_TAG_RAM_LATENCY_2_CYCLES = (2 << 6),
|
|
CACHE_TAG_RAM_LATENCY_3_CYCLES = (3 << 6),
|
|
CACHE_ENABLE_HAZARD_DETECT = (1 << 7),
|
|
CACHE_TAG_RAM_SETUP = (1 << 9),
|
|
CACHE_ECC_AND_PARITY = (1 << 21),
|
|
CACHE_ENABLE_FORCE_L2_LOGIC = (1 << 27)
|
|
};
|
|
|
|
|
|
#ifndef CONFIG_SYS_L2CACHE_OFF
|
|
/*
|
|
* Configure L2CTLR to get timings that keep us from hanging/crashing.
|
|
*
|
|
* Must be inline here since low_power_start() is called without a
|
|
* stack (!).
|
|
*/
|
|
static inline void configure_l2_ctlr(void)
|
|
{
|
|
uint32_t val;
|
|
|
|
mrc_l2_ctlr(val);
|
|
|
|
val |= CACHE_TAG_RAM_SETUP |
|
|
CACHE_DATA_RAM_SETUP |
|
|
CACHE_TAG_RAM_LATENCY_2_CYCLES |
|
|
CACHE_DATA_RAM_LATENCY_2_CYCLES;
|
|
|
|
if (proid_is_exynos5420() || proid_is_exynos5800()) {
|
|
val |= CACHE_ECC_AND_PARITY |
|
|
CACHE_TAG_RAM_LATENCY_3_CYCLES |
|
|
CACHE_DATA_RAM_LATENCY_3_CYCLES;
|
|
}
|
|
|
|
mcr_l2_ctlr(val);
|
|
}
|
|
|
|
/*
|
|
* Configure L2ACTLR.
|
|
*
|
|
* Must be inline here since low_power_start() is called without a
|
|
* stack (!).
|
|
*/
|
|
static inline void configure_l2_actlr(void)
|
|
{
|
|
uint32_t val;
|
|
|
|
if (proid_is_exynos5420() || proid_is_exynos5800()) {
|
|
mrc_l2_aux_ctlr(val);
|
|
val |= CACHE_ENABLE_FORCE_L2_LOGIC |
|
|
CACHE_DISABLE_CLEAN_EVICT;
|
|
mcr_l2_aux_ctlr(val);
|
|
}
|
|
}
|
|
#endif
|