u-boot/lib/efi_loader
Tom Rini 1c3b2f4ae1 efi_loader: Fix warning in efi_load_image()
As observed with clang:
lib/efi_loader/efi_boottime.c:1624:7: warning: variable 'info'
      is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                if (ret != EFI_SUCCESS)
                    ^~~~~~~~~~~~~~~~~~
lib/efi_loader/efi_boottime.c:1653:7: note: uninitialized use
      occurs here
        free(info);
             ^~~~
lib/efi_loader/efi_boottime.c:1624:3: note: remove the 'if' if
      its condition is always false
                if (ret != EFI_SUCCESS)
                ^~~~~~~~~~~~~~~~~~~~~~~
lib/efi_loader/efi_boottime.c:1602:31: note: initialize the
      variable 'info' to silence this warning
        struct efi_loaded_image *info;
                                     ^
                                      = NULL

Rather than change how we unwind the function it makes the most sense to
initialize info to NULL so that we can continue to pass it to free().

Fixes: c982874e93 ("efi_loader: refactor efi_setup_loaded_image()")
Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2018-10-16 16:41:18 +02:00
..
.gitignore lib: gitignore *.elf and *.so generated by efi_loader 2017-01-09 10:30:24 -05:00
efi_acpi.c efi_loader: Install ACPI configuration tables 2018-07-02 09:23:28 +08:00
efi_bootmgr.c efi_loader: rename utf16_strlen, utf16_strnlen 2018-09-23 21:55:29 +02:00
efi_boottime.c efi_loader: Fix warning in efi_load_image() 2018-10-16 16:41:18 +02:00
efi_console.c efi_loader: return type efi_console_register() 2018-10-16 16:39:38 +02:00
efi_device_path.c efi_loader: create root node 2018-09-23 21:55:31 +02:00
efi_device_path_to_text.c efi_loader: remove redundant statement 2018-09-23 21:55:31 +02:00
efi_device_path_utilities.c SPDX: Convert a few files that were missed before 2018-05-10 20:38:35 -04:00
efi_disk.c Remove <inttypes.h> includes and PRI* usages in printf() entirely 2018-09-10 20:48:17 -04:00
efi_file.c efi_loader: superfluous statement in is_dir() 2018-10-16 16:39:57 +02:00
efi_gop.c Remove <inttypes.h> includes and PRI* usages in printf() entirely 2018-09-10 20:48:17 -04:00
efi_image_loader.c efi_loader: refactor efi_setup_loaded_image() 2018-09-23 21:55:31 +02:00
efi_memory.c efi_loader: Merge memory map entries 2018-09-23 21:55:30 +02:00
efi_net.c efi_loader: remove lcd.h from efi_net.c 2018-10-16 16:40:45 +02:00
efi_root_node.c efi_loader: create root node 2018-09-23 21:55:31 +02:00
efi_runtime.c efi_loader: fix relocation on x86_64 2018-10-16 15:29:15 +02:00
efi_smbios.c Remove <inttypes.h> includes and PRI* usages in printf() entirely 2018-09-10 20:48:17 -04:00
efi_unicode_collation.c efi_loader: EFI_UNICODE_COLLATION_PROTOCOL 2018-09-23 21:55:29 +02:00
efi_variable.c efi_loader: memory leak in efi_set_variable() 2018-10-16 16:40:11 +02:00
efi_watchdog.c SPDX: Convert a few files that were missed before 2018-05-10 20:38:35 -04:00
helloworld.c efi_loader: helloworld: Output ACPI configuration table 2018-07-02 09:23:28 +08:00
Kconfig efi: sandbox: Enable EFI loader build for sandbox 2018-09-23 21:55:30 +02:00
Makefile efi_loader: create root node 2018-09-23 21:55:31 +02:00