mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-05 11:00:15 +00:00
b75d8dc564
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
28 lines
568 B
C
28 lines
568 B
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
*
|
|
* DaVinci EMAC initialization.
|
|
*
|
|
* (C) Copyright 2011, Ilya Yanok, Emcraft Systems
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <net.h>
|
|
#include <asm/io.h>
|
|
#include <asm/arch/am35x_def.h>
|
|
|
|
/*
|
|
* Initializes on-chip ethernet controllers.
|
|
* to override, implement board_eth_init()
|
|
*/
|
|
int cpu_eth_init(struct bd_info *bis)
|
|
{
|
|
u32 reset;
|
|
|
|
/* ensure that the module is out of reset */
|
|
reset = readl(&am35x_scm_general_regs->ip_sw_reset);
|
|
reset &= ~CPGMACSS_SW_RST;
|
|
writel(reset, &am35x_scm_general_regs->ip_sw_reset);
|
|
|
|
return 0;
|
|
}
|