mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-12-14 15:23:07 +00:00
f7cca7ccc5
What we were doing here amounts to simplifying the code for the new hush
parser, and the workarounds are required when using the old one. As we
have returned to having the old parser be default for now, we must undo
this so that the test passes again.
This reverts commit 6c2f753f4a.
Signed-off-by: Tom Rini <trini@konsulko.com>
225 lines
6.1 KiB
C
225 lines
6.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* (C) Copyright 2021
|
|
* Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
|
|
*/
|
|
|
|
#include <command.h>
|
|
#include <env_attr.h>
|
|
#include <test/hush.h>
|
|
#include <test/ut.h>
|
|
#include <asm/global_data.h>
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
|
|
|
static int hush_test_simple_dollar(struct unit_test_state *uts)
|
|
{
|
|
console_record_reset_enable();
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline_empty();
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("echo ${dollar_foo}", 0));
|
|
ut_assert_nextline_empty();
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_foo=bar", 0));
|
|
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("echo ${dollar_foo}", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_foo=\\$bar", 0));
|
|
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline("$bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_foo='$bar'", 0));
|
|
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline("$bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_asserteq(1, run_command("dollar_foo=bar quux", 0));
|
|
/* Next line contains error message */
|
|
ut_assert_skipline();
|
|
ut_assert_console_end();
|
|
|
|
ut_asserteq(1, run_command("dollar_foo='bar quux", 0));
|
|
/* Next line contains error message */
|
|
ut_assert_skipline();
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/*
|
|
* For some strange reasons, the console is not empty after
|
|
* running above command.
|
|
* So, we reset it to not have side effects for other tests.
|
|
*/
|
|
console_record_reset_enable();
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
ut_assert_console_end();
|
|
}
|
|
|
|
ut_asserteq(1, run_command("dollar_foo=bar quux\"", 0));
|
|
/* Two next lines contain error message */
|
|
ut_assert_skipline();
|
|
ut_assert_skipline();
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/* See above comments. */
|
|
console_record_reset_enable();
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
ut_assert_console_end();
|
|
}
|
|
|
|
ut_assertok(run_command("dollar_foo='bar \"quux'", 0));
|
|
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
/*
|
|
* This one is buggy.
|
|
* ut_assert_nextline("bar \"quux");
|
|
* ut_assert_console_end();
|
|
*
|
|
* So, let's reset output:
|
|
*/
|
|
console_record_reset_enable();
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/*
|
|
* Old parser returns an error because it waits for closing
|
|
* '\'', but this behavior is wrong as the '\'' is surrounded by
|
|
* '"', so no need to wait for a closing one.
|
|
*/
|
|
ut_assertok(run_command("dollar_foo=\"bar 'quux\"", 0));
|
|
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline("bar 'quux");
|
|
ut_assert_console_end();
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
ut_asserteq(1, run_command("dollar_foo=\"bar 'quux\"", 0));
|
|
/* Next line contains error message */
|
|
ut_assert_skipline();
|
|
ut_assert_console_end();
|
|
}
|
|
|
|
ut_assertok(run_command("dollar_foo='bar quux'", 0));
|
|
ut_assertok(run_command("echo $dollar_foo", 0));
|
|
ut_assert_nextline("bar quux");
|
|
ut_assert_console_end();
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/* Reset local variable. */
|
|
ut_assertok(run_command("dollar_foo=", 0));
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
puts("Beware: this test set local variable dollar_foo and it cannot be unset!");
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
HUSH_TEST(hush_test_simple_dollar, 0);
|
|
|
|
static int hush_test_env_dollar(struct unit_test_state *uts)
|
|
{
|
|
env_set("env_foo", "bar");
|
|
console_record_reset_enable();
|
|
|
|
ut_assertok(run_command("echo $env_foo", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("echo ${env_foo}", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
/* Environment variables have priority over local variable */
|
|
ut_assertok(run_command("env_foo=quux", 0));
|
|
ut_assertok(run_command("echo ${env_foo}", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
/* Clean up setting the variable */
|
|
env_set("env_foo", NULL);
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/* Reset local variable. */
|
|
ut_assertok(run_command("env_foo=", 0));
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
puts("Beware: this test set local variable env_foo and it cannot be unset!");
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
HUSH_TEST(hush_test_env_dollar, 0);
|
|
|
|
static int hush_test_command_dollar(struct unit_test_state *uts)
|
|
{
|
|
console_record_reset_enable();
|
|
|
|
ut_assertok(run_command("dollar_bar=\"echo bar\"", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("${dollar_bar}", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_bar=\"echo\nbar\"", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_bar='echo bar\n'", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
ut_assert_nextline("bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_bar='echo bar\\n'", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/*
|
|
* This difference seems to come from a bug solved in Busybox
|
|
* hush.
|
|
* Behavior of hush 2021 is coherent with bash and other shells.
|
|
*/
|
|
ut_assert_nextline("bar\\n");
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
ut_assert_nextline("barn");
|
|
}
|
|
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_bar='echo $bar'", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
ut_assert_nextline("$bar");
|
|
ut_assert_console_end();
|
|
|
|
ut_assertok(run_command("dollar_quux=quux", 0));
|
|
ut_assertok(run_command("dollar_bar=\"echo $dollar_quux\"", 0));
|
|
|
|
ut_assertok(run_command("$dollar_bar", 0));
|
|
ut_assert_nextline("quux");
|
|
ut_assert_console_end();
|
|
|
|
if (gd->flags & GD_FLG_HUSH_MODERN_PARSER) {
|
|
/* Reset local variables. */
|
|
ut_assertok(run_command("dollar_bar=", 0));
|
|
ut_assertok(run_command("dollar_quux=", 0));
|
|
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
|
|
puts("Beware: this test sets local variable dollar_bar and dollar_quux and they cannot be unset!");
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
HUSH_TEST(hush_test_command_dollar, 0);
|