u-boot/drivers/usb
Pali Rohár 10bc132510 usb: musb: Fix configuring FIFO for endpoints
This patch fixes configuring FIFOs for one-directional endpoints which have
only one queue (either RX or TX, but noth both).

Size of FIFO buffer is 2^(idx+3) bytes and starting address is 2^(addr+3).
Moreover first 64 bytes are reserved for EP0.

Without this patch if FIFO size specified by caller was zero then idx was
incorrectly calculated (expr. ffs(0)-1) and size overflowed in fifosz
register. This register uses has only 4 bits for FIFO size. Moreover
specifying zero buffer size is not possible (with idx=0 is minimal buffer
size 8 bytes).

So even for one-directional endpoints we need to correctly specify both
(RX and TX) FIFO buffer sizes and its addresses.

This patch is fixing calculation of start address and buffer size to
minimal value and ensures that it would not overlap with buffer reserved
for EP0.

This issue caused loose of packets on USB bus in both directions and
basically usbtty was unusable.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
2021-03-03 04:12:46 +01:00
..
cdns3 dm: core: Access device ofnode through functions 2021-01-05 12:24:41 -07:00
common common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
dwc3 Driver model: make some udevice fields private 2021-01-05 22:34:43 -05:00
emul dm: treewide: Rename ..._platdata variables to just ..._plat 2020-12-13 16:51:09 -07:00
eth Prepare v2021.01-rc5 2021-01-05 16:20:26 -05:00
gadget usb: gadget: dwc2_udc_otg: Fix dwc2_gadget_start() and usb_gadget_register_driver() 2021-02-26 15:30:55 +01:00
host dm: i2c: use CONFIG_IS_ENABLED macro for DM_I2C/DM_I2C_GPIO 2021-02-21 06:08:00 +01:00
mtu3 dm: core: Access device ofnode through functions 2021-01-05 12:24:41 -07:00
musb usb: musb: Fix configuring FIFO for endpoints 2021-03-03 04:12:46 +01:00
musb-new common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
phy common: Drop asm/global_data.h from common header 2021-02-02 15:33:42 -05:00
ulpi common: Drop linux/delay.h from common header 2020-05-18 21:19:23 -04:00
Kconfig cosmetic: fix typo in drivers/usb/Kconfig 2021-01-04 09:10:17 -05:00