u-boot/board/esd/common
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
xilinx_jtag Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
auto_update.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
auto_update.h ppc4xx: update esd's common auto_update code for 405 boards 2008-04-22 13:47:49 +02:00
cmd_loadpci.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
esd405ep_nand.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
flash.c board/esd/common/flash.c: Fix compile warning 2009-09-15 00:12:31 +02:00
fpga.c ppc4xx: Use correct io accessors for esd 405/440 boards 2009-03-20 22:39:14 +01:00
lcd.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
lcd.h ppc4xx: Use correct io accessors for esd 405/440 boards 2009-03-20 22:39:14 +01:00
misc.c Add support for multiple PHYs. 2005-10-28 22:30:33 +02:00
pci.c pci: Rename PCI_REGION_MEMORY to PCI_REGION_SYS_MEMORY for clarity 2009-02-07 23:50:04 +01:00
s1d13505_640_480_16bpp.h ppc4xx: Small coding style cleanup for the latest esd patches 2008-04-22 14:06:42 +02:00
s1d13704_320_240_4bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00
s1d13705_320_240_8bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00
s1d13806_320_240_4bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00
s1d13806_640_480_8bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00
s1d13806_640_480_16bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00
s1d13806_1024_768_8bpp.h License cleanup: Fix license header for some esd display configurations 2009-10-24 22:54:29 +02:00