u-boot/tools/imagetool.c
Pali Rohár afd82187b5 tools: imagetool: Skip autodetection of gpimage type
gpimage type requires only that two first 32-bit words of data file are
non-zero. So basically every random data file can be guessed and verified
as gpimage. So completely skip gpimage type from image autodetection code
to prevent lot of false positive results. Data file with gpimage type can
be still verified and parsed by explicitly specifying -T gpimage.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
2023-02-06 14:35:14 -05:00

194 lines
4.1 KiB
C

// SPDX-License-Identifier: GPL-2.0+
/*
* (C) Copyright 2013
*
* Written by Guilherme Maciel Ferreira <guilherme.maciel.ferreira@gmail.com>
*/
#include "imagetool.h"
#include <image.h>
struct image_type_params *imagetool_get_type(int type)
{
struct image_type_params **curr;
INIT_SECTION(image_type);
struct image_type_params **start = __start_image_type;
struct image_type_params **end = __stop_image_type;
for (curr = start; curr != end; curr++) {
if ((*curr)->check_image_type) {
if (!(*curr)->check_image_type(type))
return *curr;
}
}
return NULL;
}
static int imagetool_verify_print_header_by_type(
void *ptr,
struct stat *sbuf,
struct image_type_params *tparams,
struct image_tool_params *params);
int imagetool_verify_print_header(
void *ptr,
struct stat *sbuf,
struct image_type_params *tparams,
struct image_tool_params *params)
{
int retval = -1;
struct image_type_params **curr;
INIT_SECTION(image_type);
struct image_type_params **start = __start_image_type;
struct image_type_params **end = __stop_image_type;
if (tparams)
return imagetool_verify_print_header_by_type(ptr, sbuf, tparams, params);
for (curr = start; curr != end; curr++) {
/*
* Basically every data file can be guessed / verified as gpimage,
* so skip autodetection of data file as gpimage as it does not work.
*/
if ((*curr)->check_image_type && (*curr)->check_image_type(IH_TYPE_GPIMAGE) == 0)
continue;
if ((*curr)->verify_header) {
retval = (*curr)->verify_header((unsigned char *)ptr,
sbuf->st_size, params);
if (retval == 0) {
/*
* Print the image information if verify is
* successful
*/
if ((*curr)->print_header) {
if (!params->quiet)
(*curr)->print_header(ptr);
} else {
fprintf(stderr,
"%s: print_header undefined for %s\n",
params->cmdname, (*curr)->name);
}
break;
}
}
}
if (retval != 0) {
fprintf(stderr, "%s: cannot detect image type\n",
params->cmdname);
}
return retval;
}
static int imagetool_verify_print_header_by_type(
void *ptr,
struct stat *sbuf,
struct image_type_params *tparams,
struct image_tool_params *params)
{
int retval = -1;
if (tparams->verify_header) {
retval = tparams->verify_header((unsigned char *)ptr,
sbuf->st_size, params);
if (retval == 0) {
/*
* Print the image information if verify is successful
*/
if (tparams->print_header) {
if (!params->quiet)
tparams->print_header(ptr);
} else {
fprintf(stderr,
"%s: print_header undefined for %s\n",
params->cmdname, tparams->name);
}
} else {
fprintf(stderr,
"%s: verify_header failed for %s with exit code %d\n",
params->cmdname, tparams->name, retval);
}
} else {
fprintf(stderr, "%s: verify_header undefined for %s\n",
params->cmdname, tparams->name);
}
return retval;
}
int imagetool_save_subimage(
const char *file_name,
ulong file_data,
ulong file_len)
{
int dfd;
dfd = open(file_name, O_RDWR | O_CREAT | O_TRUNC | O_BINARY,
S_IRUSR | S_IWUSR);
if (dfd < 0) {
fprintf(stderr, "Can't open \"%s\": %s\n",
file_name, strerror(errno));
return -1;
}
if (write(dfd, (void *)file_data, file_len) != (ssize_t)file_len) {
fprintf(stderr, "Write error on \"%s\": %s\n",
file_name, strerror(errno));
close(dfd);
return -1;
}
close(dfd);
return 0;
}
int imagetool_get_filesize(struct image_tool_params *params, const char *fname)
{
struct stat sbuf;
int fd;
fd = open(fname, O_RDONLY | O_BINARY);
if (fd < 0) {
fprintf(stderr, "%s: Can't open %s: %s\n",
params->cmdname, fname, strerror(errno));
return -1;
}
if (fstat(fd, &sbuf) < 0) {
fprintf(stderr, "%s: Can't stat %s: %s\n",
params->cmdname, fname, strerror(errno));
close(fd);
return -1;
}
close(fd);
return sbuf.st_size;
}
time_t imagetool_get_source_date(
const char *cmdname,
time_t fallback)
{
char *source_date_epoch = getenv("SOURCE_DATE_EPOCH");
if (source_date_epoch == NULL)
return fallback;
time_t time = (time_t) strtol(source_date_epoch, NULL, 10);
if (gmtime(&time) == NULL) {
fprintf(stderr, "%s: SOURCE_DATE_EPOCH is not valid\n",
cmdname);
time = 0;
}
return time;
}