Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-24 13:43:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: mv88e6xxx: fix missing SMI address initialization

Browse source 
The mv88e6xxx driver does not currently initialize the smi_addr field, but
instead keeps the default zero value. This leads to driver being unusable
on devices where the switch is not on address zero of the mdio bus. Fix
this problem by reading the SMI address from device tree.

Signed-off-by: Marek Mojík <marek.mojik@nic.cz>
Reviewed-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Marek Mojík 2023-12-06 15:35:56 +01:00 committed by Stefan Roese
parent 773cb2bca7
commit faf96b20ee
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/net/mv88e6xxx.c
View file

@ -745,6 +745,7 @@ static int mv88e6xxx_probe(struct udevice *dev)
{ {
struct dsa_pdata *dsa_pdata = dev_get_uclass_plat(dev); struct dsa_pdata *dsa_pdata = dev_get_uclass_plat(dev);
struct mv88e6xxx_priv *priv = dev_get_priv(dev); struct mv88e6xxx_priv *priv = dev_get_priv(dev);
fdt_addr_t smi_addr;
int val, ret; int val, ret;
if (ofnode_valid(dev_ofnode(dev)) && if (ofnode_valid(dev_ofnode(dev)) &&
@ -753,6 +754,13 @@ static int mv88e6xxx_probe(struct udevice *dev)
return -ENODEV; return -ENODEV;
} }
smi_addr = dev_read_addr(dev);
if (smi_addr == FDT_ADDR_T_NONE) {
dev_err(dev, "Missing SMI address\n");
return -EINVAL;
}
priv->smi_addr = smi_addr;
/* probe internal mdio bus */ /* probe internal mdio bus */
ret = mv88e6xxx_probe_mdio(dev); ret = mv88e6xxx_probe_mdio(dev);
if (ret) if (ret)