From ea41b15617fa6869a6bb628dad8f972db4d77139 Mon Sep 17 00:00:00 2001 From: Heiko Schocher Date: Mon, 27 May 2019 08:14:16 +0200 Subject: [PATCH] cmd/led: check subcommand "list" instead "l" current implementation for checking if "led list" command is called checks only if "l" is passed to the led command. This prevents switching leds with name which starts also with a "l". So check for passing "list". While at it, also fix a typo in led command usage. Signed-off-by: Heiko Schocher --- cmd/led.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/led.c b/cmd/led.c index fc07ca95a3..403abbc6bc 100644 --- a/cmd/led.c +++ b/cmd/led.c @@ -85,7 +85,7 @@ int do_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) if (argc < 2) return CMD_RET_USAGE; led_label = argv[1]; - if (*led_label == 'l') + if (strncmp(led_label, "list", 4) == 0) return list_leds(); cmd = argc > 2 ? get_led_cmd(argv[2]) : LEDST_COUNT; @@ -137,6 +137,6 @@ U_BOOT_CMD( led, 4, 1, do_led, "manage LEDs", " on|off|toggle" BLINK "\tChange LED state\n" - "led [\tGet LED state\n" + "led []\tGet LED state\n" "led list\t\tshow a list of LEDs" );