Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-11 07:34:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

PCI: mediatek: Release the resource when PCIe enable port fail

Browse source 
On the mt7623 platform, if one port enable fail and other port
enable succeed. It will hang on when using pci enum
because the resource was not released correctly.

Signed-off-by: Chuanjia Liu <Chuanjia.Liu@mediatek.com>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
This commit is contained in:
Chuanjia Liu 2020-08-31 15:53:12 +08:00 committed by Tom Rini
parent a5fc58734f
commit df85e9576c
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
drivers/pci/pcie_mediatek.c
View file

@ -443,29 +443,36 @@ static void mtk_pcie_enable_port(struct mtk_pcie_port *port)
err = clk_enable(&port->sys_ck);
if (err)
goto exit;
goto err_sys_clk;
err = reset_assert(&port->reset);
if (err)
goto exit;
goto err_reset;
err = reset_deassert(&port->reset);
if (err)
goto exit;
goto err_reset;
err = generic_phy_init(&port->phy);
if (err)
goto exit;
goto err_phy_init;
err = generic_phy_power_on(&port->phy);
if (err)
goto exit;
goto err_phy_on;
if (!mtk_pcie_startup_port(port))
return;
pr_err("Port%d link down\n", port->slot);
exit:
generic_phy_power_off(&port->phy);
err_phy_on:
generic_phy_exit(&port->phy);
err_phy_init:
err_reset:
clk_disable(&port->sys_ck);
err_sys_clk:
mtk_pcie_port_free(port);
}