Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 15:14:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

lib: smbios: verify_checksum() is duplicate

Browse source 
The function verify_checksum() duplicates what table_compute_checksum()
does. Replace it. table_compute_checksum() is always compiled.

Fixes: 415eab0655 ("smbios: add parsing API")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This commit is contained in:
Heinrich Schuchardt 2023-12-26 11:22:28 +01:00
parent e3db8d60be
commit dc2fe5d84e
1 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/smbios-parser.c
View file

@ -6,21 +6,7 @@
#define LOG_CATEGORY LOGC_BOOT
#include <smbios.h>
static inline int verify_checksum(const struct smbios_entry *e)
{
/*
* Checksums for SMBIOS tables are calculated to have a value, so that
* the sum over all bytes yields zero (using unsigned 8 bit arithmetic).
*/
u8 *byte = (u8 *)e;
u8 sum = 0;
for (int i = 0; i < e->length; i++)
sum += byte[i];
return sum;
}
#include <tables_csum.h>
const struct smbios_entry *smbios_entry(u64 address, u32 size)
{
@ -32,7 +18,7 @@ const struct smbios_entry *smbios_entry(u64 address, u32 size)
if (memcmp(entry->anchor, "_SM_", 4))
return NULL;
if (verify_checksum(entry))
if (table_compute_checksum(entry, entry->length))
return NULL;
return entry;