Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-24 21:54:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

i2c: designware_i2c: remove apparently redundant read of 'i2c, speeds' DT property

Browse source 
This code first figures out if there is an i2c,speeds property, if so
its size in u32s, and then reads the value into the local speeds[]
array. Both 'size' and 'speeds' are completely unused thereafter.

It's not at all clear what this is supposed to do. Of course, it could
be seen as a sanity check that the DT node does have an i2c,speeds
property with an appropriate number of elements, but for that one
wouldn't actually need to read it into speeds[]. Also, I can't find
anywhere else in the U-Boot code which makes use of values from that
property (this is is the only C code referencing "i2c,speeds"), so it
seems pointless to insist that it's there.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
This commit is contained in:
Rasmus Villemoes 2023-03-24 09:09:22 +01:00 committed by Heiko Schocher
parent 11c25c6df0
commit d600b0fcbb
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/i2c/designware_i2c_pci.c
View file

@ -147,9 +147,7 @@ static int dw_i2c_acpi_fill_ssdt(const struct udevice *dev,
{ {
struct dw_i2c_speed_config config; struct dw_i2c_speed_config config;
char path[ACPI_PATH_MAX]; char path[ACPI_PATH_MAX];
u32 speeds[4];
uint speed; uint speed;
int size;
int ret; int ret;
/* If no device-tree node, ignore this since we assume it isn't used */ /* If no device-tree node, ignore this since we assume it isn't used */
@ -160,18 +158,6 @@ static int dw_i2c_acpi_fill_ssdt(const struct udevice *dev,
if (ret) if (ret)
return log_msg_ret("path", ret); return log_msg_ret("path", ret);
size = dev_read_size(dev, "i2c,speeds");
if (size < 0)
return log_msg_ret("i2c,speeds", -EINVAL);
size /= sizeof(u32);
if (size > ARRAY_SIZE(speeds))
return log_msg_ret("array", -E2BIG);
ret = dev_read_u32_array(dev, "i2c,speeds", speeds, size);
if (ret)
return log_msg_ret("read", -E2BIG);
speed = dev_read_u32_default(dev, "clock-frequency", 100000); speed = dev_read_u32_default(dev, "clock-frequency", 100000);
acpigen_write_scope(ctx, path); acpigen_write_scope(ctx, path);
ret = dw_i2c_gen_speed_config(dev, speed, &config); ret = dw_i2c_gen_speed_config(dev, speed, &config);