Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 07:04:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

drivers/mtd/nvmxip: Trigger post bind as probe on driver level

Browse source 
Perform all the block device creation only once, after the driver itself
successfully bound. Do not do this in uclass post bind, as this might be
triggered multiple times. For example the ut_dm_host test triggers this
and triggers a memory leak that way, since there are now multiple block
devices created using the blk_create_devicef() .

To retain the old probe-on-boot behavior, set DM_FLAG_PROBE_AFTER_BIND
flag in uclass post_bind callback, so the driver model would probe the
driver at the right time.

Rename the function as well, to match similar functions in
other block-related subsystems, like the mmc one.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
This commit is contained in:
Marek Vasut 2023-08-23 02:18:17 +02:00 committed by Tom Rini
parent 95311f7a19
commit d223dcf31a
3 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/mtd/nvmxip/nvmxip-uclass.c
View file

@ -22,17 +22,7 @@
#define DEFAULT_LBA_SZ BIT(DEFAULT_LBA_SHIFT)
/**
* nvmxip_post_bind() - post binding treatments
* @dev: the NVMXIP device
*
* Create and probe a child block device.
*
* Return:
*
* 0 on success. Otherwise, failure
*/
static int nvmxip_post_bind(struct udevice *udev)
int nvmxip_probe(struct udevice *udev)
{
int ret;
struct udevice *bdev = NULL;
@ -67,6 +57,12 @@ static int nvmxip_post_bind(struct udevice *udev)
return 0;
}
static int nvmxip_post_bind(struct udevice *udev)
{
dev_or_flags(udev, DM_FLAG_PROBE_AFTER_BIND);
return 0;
}
UCLASS_DRIVER(nvmxip) = {
.name = "nvmxip",
.id = UCLASS_NVMXIP,

1
drivers/mtd/nvmxip/nvmxip_qspi.c
View file

@ -66,5 +66,6 @@ U_BOOT_DRIVER(nvmxip_qspi) = {
.id = UCLASS_NVMXIP,
.of_match = nvmxip_qspi_ids,
.of_to_plat = nvmxip_qspi_of_to_plat,
.probe = nvmxip_probe,
.plat_auto = sizeof(struct nvmxip_plat),
};

12
include/nvmxip.h
View file

@ -29,4 +29,16 @@ struct nvmxip_plat {
lbaint_t lba;
};
/**
* nvmxip_bind() - post binding treatments
* @dev: the NVMXIP device
*
* Create and probe a child block device.
*
* Return:
*
* 0 on success. Otherwise, failure
*/
int nvmxip_probe(struct udevice *udev);
#endif /* __DRIVER_NVMXIP_H__ */