sandbox: Add a note about the growing state_info struct

This struct is getting larger and in some cases is being used for things
which would be better put into a driver. For example hwspinlock is not
used outside of sandbox_hwspinlock.c.

Add a note to encourage people to put things elsewhere.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2019-02-16 20:24:45 -07:00 committed by Bin Meng
parent 7d8fe15bb8
commit c6d84a30fe

View file

@ -102,6 +102,15 @@ struct sandbox_state {
ulong next_tag; /* Next address tag to allocate */
struct list_head mapmem_head; /* struct sandbox_mapmem_entry */
bool hwspinlock; /* Hardware Spinlock status */
/*
* This struct is getting large.
*
* Consider putting test data in driver-private structs, like
* sandbox_pch.c.
*
* If you add new members, please put them above this comment.
*/
};
/* Minimum space we guarantee in the state FDT when calling read/write*/