Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-11 07:34:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

dm: rtc: Avoid a race in the rtc_reset test

Browse source 
Since resetting the RTC on sandbox causes it to read the base time from
the system, we cannot rely on this being unchanged since it was last read.
Allow for a one-second delay.

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fixes: https://source.denx.de/u-boot/u-boot/-/issues/4
Reported-by: Bin Meng <bmeng.cn@gmail.com>
Reported-by: Tom Rini <trini@konsulko.com>
Suggested-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2022-08-01 07:58:46 -06:00 committed by Tom Rini
parent ea94d053e1
commit c4d7247a38
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
test/dm/rtc.c
View file

@ -251,10 +251,15 @@ static int dm_test_rtc_reset(struct unit_test_state *uts)
ut_asserteq(0, sandbox_i2c_rtc_get_set_base_time(emul, -1));
/* Resetting the RTC should put he base time back to normal */
/*
* Resetting the RTC should put the base time back to normal. Allow for
* a one-second adjustment in case the time flips over while this
* test process is pre-empted, since reset_time() in i2c_rtc_emul.c
* reads the time from the OS.
*/
ut_assertok(dm_rtc_reset(dev));
base_time = sandbox_i2c_rtc_get_set_base_time(emul, -1);
ut_asserteq(old_base_time, base_time);
ut_assert(base_time - old_base_time <= 1);
return 0;
}