Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-28 23:51:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

ac14xx: cleanup comments in the board support

Browse source 
fix typos, minor rephrasing, remove obsolete notes and TODO items

Signed-off-by: Gerhard Sittig <gsi@denx.de>
This commit is contained in:
Gerhard Sittig 2013-06-05 14:51:06 +02:00 committed by Wolfgang Denk
parent 186f9c130f
commit b5992e77ef
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
board/ifm/ac14xx/ac14xx.c
View file

@ -37,7 +37,7 @@ static void gpio_configure(void)
/*
* out_be32(&gpioregs->gpdir, 0xC2293020);
* workaround for a hardware affect: configure direction in pieces,
* workaround for a hardware effect: configure direction in pieces,
* setting all outputs at once drops the reset line too low and
* makes us lose the MII connection (breaks ethernet for us)
*/
@ -330,8 +330,7 @@ int misc_init_r(void)
gpio_configure();
/*
* check the GPIO keyboard,
* enforced start of the recovery when
* enforce the start of the recovery system when
* - the appropriate keys were pressed
* - a previous installation was aborted or has failed
* - "some" external software told us to
@ -339,13 +338,8 @@ int misc_init_r(void)
want_recovery = 0;
keys = gpio_querykbd();
printf("GPIO keyboard status [0x%08X]\n", keys);
/* XXX insist in the _exact_ combination? */
if ((keys & GPIOKEY_BITS_RECOVERY) == GPIOKEY_BITS_RECOVERY) {
printf("GPIO keyboard requested RECOVERY\n");
/* XXX TODO
* refine the logic to detect the first keypress, and
* wait to recheck IF it was the recovery combination?
*/
want_recovery = 1;
}
s = getenv("install_in_progress");

5
include/configs/ac14xx.h
View file

@ -72,7 +72,7 @@
#define CONFIG_SYS_MAX_RAM_SIZE 0x20000000
/*
* DDR Controller Configuration XXX TODO
* DDR Controller Configuration
*
* SYS_CFG:
* [31:31] MDDRC Soft Reset: Diabled
@ -265,7 +265,6 @@
/*
* CS related parameters
* TODO document these
*/
/* CS0 Flash */
#define CONFIG_SYS_CS0_CFG 0x00031110
@ -506,7 +505,7 @@
#define CONFIG_BOOTDELAY 2 /* -1 disables auto-boot */
/* XXX TODO need to specify the builtin environment */
/* the builtin environment and standard greeting */
#define CONFIG_PREBOOT "echo;" \
"echo Type \\\"run flash_nfs\\\" to mount root filesystem over NFS;" \
"echo"