Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 15:14:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

tools: mkimage: Call fclose in error path

Browse source 
This patch is fixing missing fclose() calls
in error patch introduced by:
"tools: mkimage: Use fstat instead of stat to avoid malicious hacks"
(sha1: ebe0f53f48)

Reported-by: Coverity (CID: 155064, 155065)
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Michal Simek 2016-12-20 09:58:31 +01:00 committed by Tom Rini
parent d0cf5512e9
commit ac71d4103e
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
tools/zynqimage.c
View file

@ -239,11 +239,15 @@ static void zynqimage_parse_initparams(struct zynq_header *zynqhdr,
}
err = fstat(fileno(fp), &path_stat);
if (err)
if (err) {
fclose(fp);
return;
}
if (!S_ISREG(path_stat.st_mode))
if (!S_ISREG(path_stat.st_mode)) {
fclose(fp);
return;
}
do {
r = fscanf(fp, "%x %x", &reginit.address, &reginit.data);

8
tools/zynqmpimage.c
View file

@ -251,11 +251,15 @@ static void zynqmpimage_parse_initparams(struct zynqmp_header *zynqhdr,
}
err = fstat(fileno(fp), &path_stat);
if (err)
if (err) {
fclose(fp);
return;
}
if (!S_ISREG(path_stat.st_mode))
if (!S_ISREG(path_stat.st_mode)) {
fclose(fp);
return;
}
do {
r = fscanf(fp, "%x %x", &reginit.address, &reginit.data);