Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-28 15:41:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

cros_ec: Use uint instead of u8 for parameters

Browse source 
There is no advantage to using a u8 for function parameters. It forces
the compiler to mask values and can increase code size. Also the command
enum has been extended to 16 bits. Update the functions to use uint
instead.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2018-11-06 15:21:18 -07:00
parent 6af7101b75
commit 9fea76f5d3
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/misc/cros_ec.c
View file

@ -227,7 +227,7 @@ static int send_command_proto3(struct cros_ec_dev *cdev,
return handle_proto3_response(cdev, dinp, din_len); return handle_proto3_response(cdev, dinp, din_len);
} }
static int send_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version, static int send_command(struct cros_ec_dev *dev, uint cmd, int cmd_version,
const void *dout, int dout_len, const void *dout, int dout_len,
uint8_t **dinp, int din_len) uint8_t **dinp, int din_len)
{ {
@ -330,7 +330,7 @@ static int ec_command_inptr(struct udevice *dev, uint8_t cmd,
* @param din_len Maximum size of response in bytes * @param din_len Maximum size of response in bytes
* @return number of bytes in response, or -ve on error * @return number of bytes in response, or -ve on error
*/ */
static int ec_command(struct udevice *dev, uint8_t cmd, int cmd_version, static int ec_command(struct udevice *dev, uint cmd, int cmd_version,
const void *dout, int dout_len, const void *dout, int dout_len,
void *din, int din_len) void *din, int din_len)
{ {
@ -650,16 +650,14 @@ static int cros_ec_check_version(struct udevice *dev)
cdev->protocol_version = 3; cdev->protocol_version = 3;
req.in_data = 0; req.in_data = 0;
if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req), if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req),
(uint8_t **)&resp, sizeof(*resp)) > 0) { (uint8_t **)&resp, sizeof(*resp)) > 0)
return 0; return 0;
}
/* Try sending a version 2 packet */ /* Try sending a version 2 packet */
cdev->protocol_version = 2; cdev->protocol_version = 2;
if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req), if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req),
(uint8_t **)&resp, sizeof(*resp)) > 0) { (uint8_t **)&resp, sizeof(*resp)) > 0)
return 0; return 0;
}
/* /*
* Fail if we're still here, since the EC doesn't understand any * Fail if we're still here, since the EC doesn't understand any