Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 23:24:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

x86: ivybridge: Move northbridge and PCH init into drivers

Browse source 
Instead of calling the northbridge and PCH init from bd82x6x_init_extra()
when the PCI bus is probed, call it from the respective drivers. Also drop
the Northbridge init as it has no effect. The registers it touches appear to
be read-only.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2016-01-17 16:11:31 -07:00 committed by Bin Meng
parent ac643e0363
commit 9ed781a6ff
4 changed files with 12 additions and 55 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
arch/x86/cpu/ivybridge/bd82x6x.c
View file

@ -18,45 +18,6 @@
#define BIOS_CTRL 0xdc
void bd82x6x_pci_init(pci_dev_t dev)
{
u16 reg16;
u8 reg8;
debug("bd82x6x PCI init.\n");
/* Enable Bus Master */
reg16 = x86_pci_read_config16(dev, PCI_COMMAND);
reg16 |= PCI_COMMAND_MASTER;
x86_pci_write_config16(dev, PCI_COMMAND, reg16);
/* This device has no interrupt */
x86_pci_write_config8(dev, INTR, 0xff);
/* disable parity error response and SERR */
reg16 = x86_pci_read_config16(dev, BCTRL);
reg16 &= ~(1 << 0);
reg16 &= ~(1 << 1);
x86_pci_write_config16(dev, BCTRL, reg16);
/* Master Latency Count must be set to 0x04! */
reg8 = x86_pci_read_config8(dev, SMLT);
reg8 &= 0x07;
reg8 |= (0x04 << 3);
x86_pci_write_config8(dev, SMLT, reg8);
/* Will this improve throughput of bus masters? */
x86_pci_write_config8(dev, PCI_MIN_GNT, 0x06);
/* Clear errors in status registers */
reg16 = x86_pci_read_config16(dev, PSTS);
/* reg16 |= 0xf900; */
x86_pci_write_config16(dev, PSTS, reg16);
reg16 = x86_pci_read_config16(dev, SECSTS);
/* reg16 |= 0xf900; */
x86_pci_write_config16(dev, SECSTS, reg16);
}
static int bd82x6x_probe(struct udevice *dev)
{
const void *blob = gd->fdt_blob;
@ -108,10 +69,7 @@ int bd82x6x_init_extra(void)
return -EINVAL;
}
bd82x6x_pci_init(PCH_DEV);
bd82x6x_sata_enable(PCH_SATA_DEV, blob, sata_node);
northbridge_enable(PCH_DEV);
northbridge_init(PCH_DEV);
return 0;
}

16
arch/x86/cpu/ivybridge/northbridge.c
View file

@ -197,15 +197,12 @@ static void sandybridge_setup_northbridge_bars(struct udevice *dev)
dm_pci_write_config8(dev, PAM6, 0x33);
}
static int bd82x6x_northbridge_probe(struct udevice *dev)
static int bd82x6x_northbridge_early_init(struct udevice *dev)
{
const int chipset_type = SANDYBRIDGE_MOBILE;
u32 capid0_a;
u8 reg8;
if (gd->flags & GD_FLG_RELOC)
return 0;
/* Device ID Override Enable should be done very early */
dm_pci_read_config32(dev, 0xe4, &capid0_a);
if (capid0_a & (1 << 10)) {
@ -226,6 +223,17 @@ static int bd82x6x_northbridge_probe(struct udevice *dev)
return 0;
}
static int bd82x6x_northbridge_probe(struct udevice *dev)
{
if (!(gd->flags & GD_FLG_RELOC))
return bd82x6x_northbridge_early_init(dev);
northbridge_enable(PCH_DEV);
northbridge_init(PCH_DEV);
return 0;
}
static const struct udevice_id bd82x6x_northbridge_ids[] = {
{ .compatible = "intel,bd82x6x-northbridge" },
{ }

1
arch/x86/include/asm/arch-ivybridge/bd82x6x.h
View file

@ -9,7 +9,6 @@
void bd82x6x_sata_init(pci_dev_t dev, const void *blob, int node);
void bd82x6x_sata_enable(pci_dev_t dev, const void *blob, int node);
void bd82x6x_pci_init(pci_dev_t dev);
void bd82x6x_usb_ehci_init(pci_dev_t dev);
void bd82x6x_usb_xhci_init(pci_dev_t dev);
int gma_func0_init(struct udevice *dev, const void *blob, int node);

8
board/google/chromebook_link/link.c
View file

@ -14,14 +14,6 @@
int arch_early_init_r(void)
{
struct udevice *dev;
int ret;
/* Make sure the platform controller hub is up and running */
ret = uclass_get_device(UCLASS_PCH, 0, &dev);
if (ret)
return ret;
return 0;
}