mirror of
https://github.com/AsahiLinux/u-boot
synced 2025-02-18 06:58:54 +00:00
PCI_READ_VIA_DWORD_OP: Fix *val uninitialized bug
This patch has been sent on: - 6 Jun 2007 Many users of PCI config read routines tend to ignore the function ret value, and are only concerned about the contents of *val. Based on this, pci_hose_read_config_{byte,word}_via_dword should initialize the *val on dword read error. Without this fix, for example, we'll go on scanning bus with vendor or header_type uninitialized. This brings many unnecessary config trials. Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
This commit is contained in:
parent
d35b508a55
commit
815b5bd5b1
1 changed files with 3 additions and 1 deletions
|
@ -82,8 +82,10 @@ int pci_hose_read_config_##size##_via_dword(struct pci_controller *hose,\
|
|||
{ \
|
||||
u32 val32; \
|
||||
\
|
||||
if (pci_hose_read_config_dword(hose, dev, offset & 0xfc, &val32) < 0)\
|
||||
if (pci_hose_read_config_dword(hose, dev, offset & 0xfc, &val32) < 0) { \
|
||||
*val = -1; \
|
||||
return -1; \
|
||||
} \
|
||||
\
|
||||
*val = (val32 >> ((offset & (int)off_mask) * 8)); \
|
||||
\
|
||||
|
|
Loading…
Add table
Reference in a new issue