Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 23:24:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

tools: kwboot: Fix quitting terminal

Browse source 
Sometimes kwboot after quitting terminal prints error message:

  terminal: Bad address

This is caused by trying to call write() syscall with count of (size_t)-1
bytes.

When quit sequence is split into more read() calls then number of input
bytes (nin) at the end of cycle can underflow and be negative. Fix it.

Fixes: de7514046e ("tools: kwboot: Fix detection of quit esc sequence")
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Pali Rohár 2022-02-18 12:24:13 +01:00 committed by Stefan Roese
parent d274f92246
commit 7938b3be7c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/kwboot.c
View file

@ -1197,7 +1197,7 @@ kwboot_term_pipe(int in, int out, const char *quit, int *s)
if (buf[i] == quit[*s]) {
(*s)++;
if (!quit[*s]) {
nin = i - *s;
nin = (i > *s) ? (i - *s) : 0;
break;
}
} else {
@ -1208,7 +1208,7 @@ kwboot_term_pipe(int in, int out, const char *quit, int *s)
}
if (i == nin)
nin -= *s;
nin -= (nin > *s) ? *s : nin;
}
if (kwboot_write(out, buf, nin) < 0)