Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-29 16:10:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

x86: pinctrl: Set up itss in the probe() method

Browse source 
At present the itss is probed in the ofdata_to_platdata() method. This is
incorrect since itss is a child of p2sb which itself needs to probe the
pinctrl device. This means that p2sb is effectively not probed when the
itss is probed, so we get the wrong register address from p2sb.

Fix this by moving the itss probe to the correct place.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
This commit is contained in:
Simon Glass 2020-07-07 21:32:22 -06:00 committed by Bin Meng
parent a9331a3388
commit 6b651486f5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/pinctrl/intel/pinctrl.c
View file

@ -619,15 +619,11 @@ int intel_pinctrl_ofdata_to_platdata(struct udevice *dev,
{ {
struct p2sb_child_platdata *pplat = dev_get_parent_platdata(dev); struct p2sb_child_platdata *pplat = dev_get_parent_platdata(dev);
struct intel_pinctrl_priv *priv = dev_get_priv(dev); struct intel_pinctrl_priv *priv = dev_get_priv(dev);
int ret;
if (!comm) { if (!comm) {
log_err("Cannot find community for pid %d\n", pplat->pid); log_err("Cannot find community for pid %d\n", pplat->pid);
return -EDOM; return -EDOM;
} }
ret = irq_first_device_type(X86_IRQT_ITSS, &priv->itss);
if (ret)
return log_msg_ret("Cannot find ITSS", ret);
priv->comm = comm; priv->comm = comm;
priv->num_cfgs = num_cfgs; priv->num_cfgs = num_cfgs;
@ -637,8 +633,12 @@ int intel_pinctrl_ofdata_to_platdata(struct udevice *dev,
int intel_pinctrl_probe(struct udevice *dev) int intel_pinctrl_probe(struct udevice *dev)
{ {
struct intel_pinctrl_priv *priv = dev_get_priv(dev); struct intel_pinctrl_priv *priv = dev_get_priv(dev);
int ret;
priv->itss_pol_cfg = true; priv->itss_pol_cfg = true;
ret = irq_first_device_type(X86_IRQT_ITSS, &priv->itss);
if (ret)
return log_msg_ret("Cannot find ITSS", ret);
return 0; return 0;
} }