Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 07:04:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

tools: avoid implicit fallthrough in fdt_add_pubkey

Browse source 
When building with -Wimplicit-fallthrough we get a warning

    tools/fdt_add_pubkey.c:52:25: warning:
    this statement may fall through [-Wimplicit-fallthrough=]
       52 |                         print_help();
          |

Explicitly declare which functions don't return.

Fixes: 30238e9961 ("tools: add fdt_add_pubkey")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Heinrich Schuchardt 2023-04-01 08:09:34 +02:00 committed by Tom Rini
parent aeb40f1166
commit 686e9ef605
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/fdt_add_pubkey.c
View file

@ -10,7 +10,7 @@ static const char *keyname = "key"; /* -n <keyname> */
static const char *require_keys; /* -r <conf|image> */ static const char *require_keys; /* -r <conf|image> */
static const char *keydest; /* argv[n] */ static const char *keydest; /* argv[n] */
static void print_usage(const char *msg) static void __attribute__((__noreturn__)) print_usage(const char *msg)
{ {
fprintf(stderr, "Error: %s\n", msg); fprintf(stderr, "Error: %s\n", msg);
fprintf(stderr, "Usage: %s [-a <algo>] [-k <keydir>] [-n <keyname>] [-r <conf|image>]" fprintf(stderr, "Usage: %s [-a <algo>] [-k <keydir>] [-n <keyname>] [-r <conf|image>]"
@ -19,7 +19,7 @@ static void print_usage(const char *msg)
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
static void print_help(void) static void __attribute__((__noreturn__)) print_help(void)
{ {
fprintf(stderr, "Options:\n" fprintf(stderr, "Options:\n"
"\t-a <algo> Cryptographic algorithm. Optional parameter, default value: sha1,rsa2048\n" "\t-a <algo> Cryptographic algorithm. Optional parameter, default value: sha1,rsa2048\n"