buildman: Drop the 'active' flag in the builder

This serves no real purpose, since when we are not active, we exit. Drop it.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2016-09-18 16:48:36 -06:00 committed by sjg
parent d436e38189
commit 63781bd65e
2 changed files with 1 additions and 16 deletions

View file

@ -127,7 +127,6 @@ class Builder:
"""Class for building U-Boot for a particular commit. """Class for building U-Boot for a particular commit.
Public members: (many should ->private) Public members: (many should ->private)
active: True if the builder is active and has not been stopped
already_done: Number of builds already completed already_done: Number of builds already completed
base_dir: Base directory to use for builder base_dir: Base directory to use for builder
checkout: True to check out source, False to skip that step. checkout: True to check out source, False to skip that step.
@ -235,7 +234,6 @@ class Builder:
self.base_dir = base_dir self.base_dir = base_dir
self._working_dir = os.path.join(base_dir, '.bm-work') self._working_dir = os.path.join(base_dir, '.bm-work')
self.threads = [] self.threads = []
self.active = True
self.do_make = self.Make self.do_make = self.Make
self.gnu_make = gnu_make self.gnu_make = gnu_make
self.checkout = checkout self.checkout = checkout
@ -390,11 +388,6 @@ class Builder:
if result: if result:
target = result.brd.target target = result.brd.target
if result.return_code < 0:
self.active = False
command.StopAll()
return
self.upto += 1 self.upto += 1
if result.return_code != 0: if result.return_code != 0:
self.fail += 1 self.fail += 1

View file

@ -473,14 +473,6 @@ class BuilderThread(threading.Thread):
alive = True alive = True
while True: while True:
job = self.builder.queue.get() job = self.builder.queue.get()
if self.builder.active and alive: if alive:
self.RunJob(job) self.RunJob(job)
'''
try:
if self.builder.active and alive:
self.RunJob(job)
except Exception as err:
alive = False
print err
'''
self.builder.queue.task_done() self.builder.queue.task_done()