Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-14 00:47:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

checkpatch.pl: Add warning for new __packed additions

Browse source 
While there are valid reasons to use __packed, often the answer is that
you should be doing something else here instead.

This reintroduces the changes of
f503cc49a5 (Add warning for new __packed additions)

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2017-09-13 04:59:05 +02:00 committed by Tom Rini
parent e2888a7fa7
commit 5c761ce586
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scripts/checkpatch.pl
View file

@ -5616,6 +5616,13 @@ sub process {
"__packed is preferred over __attribute__((packed))\n" . $herecurr); "__packed is preferred over __attribute__((packed))\n" . $herecurr);
} }
# Check for new packed members, warn to use care
if ($realfile !~ m@\binclude/uapi/@ &&
$line =~ /\b(__attribute__\s*\(\s*\(.*\bpacked|__packed)\b/) {
WARN("NEW_PACKED",
"Adding new packed members is to be done with care\n" . $herecurr);
}
# Check for __attribute__ aligned, prefer __aligned # Check for __attribute__ aligned, prefer __aligned
if ($realfile !~ m@\binclude/uapi/@ && if ($realfile !~ m@\binclude/uapi/@ &&
$line =~ /\b__attribute__\s*\(\s*\(.*aligned/) { $line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {