Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2025-02-17 22:49:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

i2c: Correct command return values

Browse source 
We should not return a -ve error code from command functions. Instead,
return CMD_RET_FAILURE. This avoids the "exit not allowed from main input
shell" error messages from the hush shell.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Heiko Schocher <hs@denx.de>
This commit is contained in:
Simon Glass 2015-12-29 05:22:50 -07:00
parent 4a1db6d8ab
commit 4fbd258e69
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
common/cmd_i2c.c
View file

@ -1809,7 +1809,8 @@ static int do_i2c_bus_num(cmd_tbl_t *cmdtp, int flag, int argc,
if (ret) if (ret)
printf("Failure changing bus number (%d)\n", ret); printf("Failure changing bus number (%d)\n", ret);
} }
return ret;
return ret ? CMD_RET_FAILURE : 0;
} }
#endif /* defined(CONFIG_SYS_I2C) */ #endif /* defined(CONFIG_SYS_I2C) */
@ -1852,7 +1853,8 @@ static int do_i2c_bus_speed(cmd_tbl_t * cmdtp, int flag, int argc, char * const
if (ret) if (ret)
printf("Failure changing bus speed (%d)\n", ret); printf("Failure changing bus speed (%d)\n", ret);
} }
return ret;
return ret ? CMD_RET_FAILURE : 0;
} }
/** /**