Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 23:24:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

buildman: Rename the good, better, worse variables

Browse source 
At present we don't distinguish between errors and warnings when printing
the architecture summary. Rename the variables to better describe their
purpose.

'Worse' at present means we got an error, so use that as the name.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2018-11-06 16:02:12 -07:00
parent 2d48333e44
commit 4cf2b221c6
1 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
tools/buildman/builder.py
View file

@ -1196,10 +1196,10 @@ class Builder:
Print(' ' + line, newline=True, colour=col) Print(' ' + line, newline=True, colour=col)
better = [] # List of boards fixed since last commit ok_boards = [] # List of boards fixed since last commit
worse = [] # List of new broken boards since last commit err_boards = [] # List of new broken boards since last commit
new = [] # List of boards that didn't exist last time new_boards = [] # List of boards that didn't exist last time
unknown = [] # List of boards that were not built unknown_boards = [] # List of boards that were not built
for target in board_dict: for target in board_dict:
if target not in board_selected: if target not in board_selected:
@ -1210,13 +1210,13 @@ class Builder:
base_outcome = self._base_board_dict[target].rc base_outcome = self._base_board_dict[target].rc
outcome = board_dict[target] outcome = board_dict[target]
if outcome.rc == OUTCOME_UNKNOWN: if outcome.rc == OUTCOME_UNKNOWN:
unknown.append(target) unknown_boards.append(target)
elif outcome.rc < base_outcome: elif outcome.rc < base_outcome:
better.append(target) ok_boards.append(target)
elif outcome.rc > base_outcome: elif outcome.rc > base_outcome:
worse.append(target) err_boards.append(target)
else: else:
new.append(target) new_boards.append(target)
# Get a list of errors that have appeared, and disappeared # Get a list of errors that have appeared, and disappeared
better_err, worse_err = _CalcErrorDelta(self._base_err_lines, better_err, worse_err = _CalcErrorDelta(self._base_err_lines,
@ -1225,16 +1225,16 @@ class Builder:
self._base_warn_line_boards, warn_lines, warn_line_boards, 'w') self._base_warn_line_boards, warn_lines, warn_line_boards, 'w')
# Display results by arch # Display results by arch
if (better or worse or unknown or new or worse_err or better_err if any((ok_boards, err_boards, unknown_boards, new_boards, worse_err,
or worse_warn or better_warn): better_err, worse_warn, better_warn)):
arch_list = {} arch_list = {}
self.AddOutcome(board_selected, arch_list, better, '', self.AddOutcome(board_selected, arch_list, ok_boards, '',
self.col.GREEN) self.col.GREEN)
self.AddOutcome(board_selected, arch_list, worse, '+', self.AddOutcome(board_selected, arch_list, err_boards, '+',
self.col.RED) self.col.RED)
self.AddOutcome(board_selected, arch_list, new, '*', self.col.BLUE) self.AddOutcome(board_selected, arch_list, new_boards, '*', self.col.BLUE)
if self._show_unknown: if self._show_unknown:
self.AddOutcome(board_selected, arch_list, unknown, '?', self.AddOutcome(board_selected, arch_list, unknown_boards, '?',
self.col.MAGENTA) self.col.MAGENTA)
for arch, target_list in arch_list.iteritems(): for arch, target_list in arch_list.iteritems():
Print('%10s: %s' % (arch, target_list)) Print('%10s: %s' % (arch, target_list))