tools/env: return with error if redundant environments have unequal size

For double buffering to work, the target buffer must always be big
enough to hold all data. This can only be ensured if buffers are of
equal size, otherwise one must be smaller and we risk data loss
when copying from the bigger to the smaller buffer.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Andreas Fenkart <andreas.fenkart@digitalstrom.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Andreas Fenkart 2016-08-17 23:41:53 +02:00 committed by Tom Rini
parent c359ae5e8b
commit 490365c38f

5
tools/env/fw_env.c vendored
View file

@ -1423,10 +1423,9 @@ static int parse_config(struct env_opts *opts)
return rc; return rc;
if (ENVSIZE(0) != ENVSIZE(1)) { if (ENVSIZE(0) != ENVSIZE(1)) {
ENVSIZE(0) = ENVSIZE(1) = min(ENVSIZE(0), ENVSIZE(1));
fprintf(stderr, fprintf(stderr,
"Redundant environments have inequal size, set to 0x%08lx\n", "Redundant environments have unequal size");
ENVSIZE(1)); return -1;
} }
} }