Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-24 21:54:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

buildman: Drop warning about orphaned defconfigs

Browse source 
Some boards use a MAINTAINERS entry to specify common files without
referencing any defconfigs. This is allowed and should not result in a
warning.

Drop the warning in this case.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2023-08-03 12:51:37 -06:00
parent 1c81e0808b
commit 48d4c0a85d
2 changed files with 2 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tools/buildman/boards.py
View file

@ -377,16 +377,9 @@ class MaintainersDatabase:
Args: Args:
linenum (int): Current line number linenum (int): Current line number
""" """
added = False
if targets: if targets:
for target in targets: for target in targets:
self.database[target] = (status, maintainers) self.database[target] = (status, maintainers)
added = True
if not added and (status != '-' and maintainers):
leaf = fname[len(srcdir) + 1:]
if leaf != 'MAINTAINERS':
self.warnings.append(
f'WARNING: orphaned defconfig in {leaf} ending at line {linenum + 1}')
targets = [] targets = []
maintainers = [] maintainers = []

9
tools/buildman/func_test.py
View file

@ -926,10 +926,7 @@ Active aarch64 armv8 - armltd total_compute board2
tools.write_file(main, data, binary=False) tools.write_file(main, data, binary=False)
params_list, warnings = self._boards.build_board_list(config_dir, src) params_list, warnings = self._boards.build_board_list(config_dir, src)
self.assertEquals(2, len(params_list)) self.assertEquals(2, len(params_list))
self.assertEquals( self.assertEquals(["WARNING: no maintainers for 'board0'"], warnings)
["WARNING: no maintainers for 'board0'",
'WARNING: orphaned defconfig in boards/board0/MAINTAINERS ending at line 4',
], warnings)
# Mark a board as orphaned - this should give a warning # Mark a board as orphaned - this should give a warning
lines = ['S: Orphaned' if line.startswith('S') else line lines = ['S: Orphaned' if line.startswith('S') else line
@ -969,9 +966,7 @@ Active aarch64 armv8 - armltd total_compute board2
tools.write_file(main, both_data + extra, binary=False) tools.write_file(main, both_data + extra, binary=False)
params_list, warnings = self._boards.build_board_list(config_dir, src) params_list, warnings = self._boards.build_board_list(config_dir, src)
self.assertEquals(2, len(params_list)) self.assertEquals(2, len(params_list))
self.assertEquals( self.assertFalse(warnings)
['WARNING: orphaned defconfig in boards/board0/MAINTAINERS ending at line 16'],
warnings)
# Add another TARGET to the Kconfig # Add another TARGET to the Kconfig
tools.write_file(main, both_data, binary=False) tools.write_file(main, both_data, binary=False)