Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-25 14:10:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

x86: fsp: Add comments about U-Boot entering start.S twice

Browse source 
Add some comments in start.S for the fact that with FSP U-Boot
actually enters the code twice. Also change to use fsp_init()
and fsp_continue for accuracy.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Bin Meng 2015-08-20 06:40:20 -07:00 committed by Simon Glass
parent 57b10f59b7
commit 48aa6c2614
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
arch/x86/Kconfig
View file

@ -229,7 +229,7 @@ config FSP_TEMP_RAM_ADDR
depends on HAVE_FSP depends on HAVE_FSP
default 0x2000000 default 0x2000000
help help
Stack top address which is used in FspInit after DRAM is ready and Stack top address which is used in fsp_init() after DRAM is ready and
CAR is disabled. CAR is disabled.
config FSP_SYS_MALLOC_F_LEN config FSP_SYS_MALLOC_F_LEN

6
arch/x86/cpu/start.S
View file

@ -115,8 +115,10 @@ car_init_ret:
#endif #endif
#else #else
/* /*
* When we get here after car_init(), esp points to a temporary stack * U-Boot enters here twice. For the first time it comes from
* and esi holds the HOB list address returned by the FSP. * car_init_done() with esp points to a temporary stack and esi
* set to zero. For the second time it comes from fsp_init_done()
* with esi holding the HOB list address returned by the FSP.
*/ */
#endif #endif
/* Set up global data */ /* Set up global data */

2
arch/x86/lib/fsp/fsp_car.S
View file

@ -64,7 +64,7 @@ temp_ram_init_ret:
.global fsp_init_done .global fsp_init_done
fsp_init_done: fsp_init_done:
/* /*
* We come here from FspInit with eax pointing to the HOB list. * We come here from fsp_continue() with eax pointing to the HOB list.
* Save eax to esi temporarily. * Save eax to esi temporarily.
*/ */
movl %eax, %esi movl %eax, %esi