Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-28 15:41:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd: itest: correct calculus for long format

Browse source 
itest shell command doesn't work correctly in long format when
doing comparaison due to wrong mask value calculus that overflow
on 32 bits values.

Signed-off-by: Sebastien Colleur <sebastienx.colleur@intel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Sebastien Colleur 2017-02-10 15:59:15 +03:00 committed by Tom Rini
parent 2cfe312258
commit 2c79fd4019
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cmd/itest.c
View file

@ -80,7 +80,8 @@ static long evalexp(char *s, int w)
l = simple_strtoul(s, NULL, 16); l = simple_strtoul(s, NULL, 16);
} }
return l & ((1UL << (w * 8)) - 1); /* avoid overflow on mask calculus */
return (w >= sizeof(long)) ? l : (l & ((1UL << (w * 8)) - 1));
} }
static char * evalstr(char *s) static char * evalstr(char *s)