Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-28 07:31:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd: bind: Try to improve the (un)bind help

Browse source 
While it may sound totally obvious for the regular U-Boot developer to
get the parameters of the bind/unbind commands from the output of 'dm
tree', it did not felt straightforward to me until I was explicitly
told to look there. And even when I knew the command, I did not make a
direct link between the arguments of this command and the columns
returned by 'dm tree'.

Several of us lost a lot of time because of that, I would like to kindly
help other users by slightly improving this textual line. Unfortunately,
because of how this string is used (like within the 'help' command) I
cannot detail much more, but at least the pointer is there.

While we add this message, we can also imply CMD_DM when we enable
CMD_BIND so the debug message does not lead to an unknown command. This
way the 'dm' command will likely be there unless explicitly disabled.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20231010090304.49335-3-miquel.raynal@bootlin.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
This commit is contained in:
Miquel Raynal 2023-10-10 11:03:03 +02:00 committed by Mattijs Korpershoek
parent 9b63fcaec6
commit 249a75d8e8
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cmd/Kconfig
View file

@ -977,6 +977,7 @@ config CMD_BCB
config CMD_BIND config CMD_BIND
bool "bind/unbind - Bind or unbind a device to/from a driver" bool "bind/unbind - Bind or unbind a device to/from a driver"
depends on DM depends on DM
imply CMD_DM
help help
Bind or unbind a device to/from a driver from the command line. Bind or unbind a device to/from a driver from the command line.
This is useful in situations where a device may be handled by several This is useful in situations where a device may be handled by several

4
cmd/bind.c
View file

@ -246,6 +246,8 @@ U_BOOT_CMD(
"Bind a device to a driver", "Bind a device to a driver",
"<node path> <driver>\n" "<node path> <driver>\n"
"bind <class> <index> <driver>\n" "bind <class> <index> <driver>\n"
"Use 'dm tree' to list all devices registered in the driver model,\n"
"their path, class, index and current driver.\n"
); );
U_BOOT_CMD( U_BOOT_CMD(
@ -254,4 +256,6 @@ U_BOOT_CMD(
"<node path>\n" "<node path>\n"
"unbind <class> <index>\n" "unbind <class> <index>\n"
"unbind <class> <index> <driver>\n" "unbind <class> <index> <driver>\n"
"Use 'dm tree' to list all devices registered in the driver model,\n"
"their path, class, index and current driver.\n"
); );