Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-25 06:00:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

cros_ec: Fix two bugs in the SPI implementation

Browse source 
An incorrect message version is passed to the EC in some cases and the
parameters of one function are switched.

Fix these problems.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Ajay Kumar <ajaykumar.rs@samsung.com>
Reviewed-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
This commit is contained in:
Simon Glass 2014-07-07 10:16:37 -06:00 committed by Jagannadha Sutradharudu Teki
parent a52a178f0b
commit 2001b9a641
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/misc/cros_ec_spi.c
View file

@ -98,7 +98,7 @@ int cros_ec_spi_command(struct cros_ec_dev *dev, uint8_t cmd, int cmd_version,
} }
out = dev->dout; out = dev->dout;
out[0] = cmd_version; out[0] = EC_CMD_VERSION0 + cmd_version;
out[1] = cmd; out[1] = cmd;
out[2] = (uint8_t)dout_len; out[2] = (uint8_t)dout_len;
memcpy(out + 3, dout, dout_len); memcpy(out + 3, dout, dout_len);
@ -165,7 +165,7 @@ int cros_ec_spi_decode_fdt(struct cros_ec_dev *dev, const void *blob)
*/ */
int cros_ec_spi_init(struct cros_ec_dev *dev, const void *blob) int cros_ec_spi_init(struct cros_ec_dev *dev, const void *blob)
{ {
dev->spi = spi_setup_slave_fdt(blob, dev->parent_node, dev->node); dev->spi = spi_setup_slave_fdt(blob, dev->node, dev->parent_node);
if (!dev->spi) { if (!dev->spi) {
debug("%s: Could not setup SPI slave\n", __func__); debug("%s: Could not setup SPI slave\n", __func__);
return -1; return -1;