sysinfo: gpio: fix loop over DT "revisions" array

There can certainly be a lot more elements in the "revisions" (and
"names") arrays than there are gpios used to form the trinary number
we're searching for; we simply don't know the array size up-front.

Nor do we need to, because the loop body already knows to recognize
-EOVERFLOW as "not that many elements present" (and we have a test
that specifically ensures that dev_read_u32_index() returns exactly
that). So just drop the i < priv->gpio_num condition.

While in here, fix the weird placement of the default: keyword.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Sean Anderson <sean.anderson@seco.com>
This commit is contained in:
Rasmus Villemoes 2023-03-10 11:58:03 +01:00 committed by Tom Rini
parent 732b082547
commit 19213d7a65

View file

@ -57,7 +57,7 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char *
int i, ret; int i, ret;
u32 revision; u32 revision;
for (i = 0; i < priv->gpio_num; i++) { for (i = 0; ; i++) {
ret = dev_read_u32_index(dev, "revisions", i, ret = dev_read_u32_index(dev, "revisions", i,
&revision); &revision);
if (ret) { if (ret) {
@ -80,7 +80,8 @@ static int sysinfo_gpio_get_str(struct udevice *dev, int id, size_t size, char *
strncpy(val, name, size); strncpy(val, name, size);
val[size - 1] = '\0'; val[size - 1] = '\0';
return 0; return 0;
} default: }
default:
return -EINVAL; return -EINVAL;
}; };
} }