Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-09-21 07:01:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

cmd: mvebu/bubt: Fix cmd main return value on error

Browse source 
Negative return value from cmd main function cause U-Boot to print criplic
error message: exit not allowed from main input shell.

Set return value on error to 1.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
This commit is contained in:
Pali Rohár 2022-07-26 16:11:59 +02:00 committed by Stefan Roese
parent 93c1358bcd
commit 09b0e20d73
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cmd/mvebu/bubt.c
View file

@ -870,11 +870,11 @@ int do_bubt_cmd(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
dst = find_bubt_dev(dst_dev_name); dst = find_bubt_dev(dst_dev_name);
if (!dst) { if (!dst) {
printf("Error: Unknown destination \"%s\"\n", dst_dev_name); printf("Error: Unknown destination \"%s\"\n", dst_dev_name);
return -EINVAL; return 1;
} }
if (!bubt_is_dev_active(dst)) if (!bubt_is_dev_active(dst))
return -ENODEV; return 1;
/* Figure out the source device */ /* Figure out the source device */
src = find_bubt_dev(src_dev_name); src = find_bubt_dev(src_dev_name);
@ -891,15 +891,15 @@ int do_bubt_cmd(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
image_size = bubt_read_file(src); image_size = bubt_read_file(src);
if (!image_size) if (!image_size)
return -EIO; return 1;
err = bubt_verify(dst); err = bubt_verify(dst);
if (err) if (err)
return err; return 1;
err = bubt_write_file(dst, image_size); err = bubt_write_file(dst, image_size);
if (err) if (err)
return err; return 1;
return 0; return 0;
} }