Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2025-02-17 22:49:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

efi_selftest: block device: avoid read after free

Browse source 
Reading the position in a file after closing the same results in a read
after free.

Correct the sequence in the test.

Reported-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Heinrich Schuchardt 2018-12-22 00:37:41 +01:00 • committed by Alexander Graf
parent 1f2e948d6d
commit 05aceb2b1c
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/efi_selftest/efi_selftest_block_device.c
View file

@ -445,11 +445,6 @@ static int execute(void)
efi_st_error("Failed to write file\n"); efi_st_error("Failed to write file\n");
return EFI_ST_FAILURE; return EFI_ST_FAILURE;
} }
ret = file->close(file);
if (ret != EFI_SUCCESS) {
efi_st_error("Failed to close file\n");
return EFI_ST_FAILURE;
}
ret = file->getpos(file, &pos); ret = file->getpos(file, &pos);
if (ret != EFI_SUCCESS) { if (ret != EFI_SUCCESS) {
efi_st_error("GetPosition failed\n"); efi_st_error("GetPosition failed\n");
@ -460,6 +455,11 @@ static int execute(void)
(unsigned int)pos); (unsigned int)pos);
return EFI_ST_FAILURE; return EFI_ST_FAILURE;
} }
ret = file->close(file);
if (ret != EFI_SUCCESS) {
efi_st_error("Failed to close file\n");
return EFI_ST_FAILURE;
}
/* Verify file */ /* Verify file */
boottime->set_mem(buf, sizeof(buf), 0); boottime->set_mem(buf, sizeof(buf), 0);