Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-11 15:37:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

83xx: mpc8315erdb: fix silly thinko in fdt_tsec1_fixup

Browse source 
The thinko was quite silly indeed, I messed with !ptr. Normally this
would trigger some fault, but in U-Boot NULL pointer is equal to phys
0, so the code was working still, just didn't actually test mpc8315erdb
environment variable value. Heh.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
This commit is contained in:
Anton Vorontsov 2008-07-10 17:20:51 +04:00 committed by Kim Phillips
parent 25f5f0d49a
commit 021f6df6e9
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
board/freescale/mpc8315erdb/mpc8315erdb.c
View file

@ -128,15 +128,16 @@ void fdt_tsec1_fixup(void *fdt, bd_t *bd)
const char *path;
int ret;
if (!mpc8315erdb) {
if (!strcmp(mpc8315erdb, "tsec1")) {
return;
} else if (strcmp(mpc8315erdb, "ulpi")) {
printf("WARNING: wrong `mpc8315erdb' environment "
"variable specified: `%s'. Should be `ulpi' "
"or `tsec1'.\n", mpc8315erdb);
return;
}
if (!mpc8315erdb)
return;
if (!strcmp(mpc8315erdb, "tsec1")) {
return;
} else if (strcmp(mpc8315erdb, "ulpi")) {
printf("WARNING: wrong `mpc8315erdb' environment "
"variable specified: `%s'. Should be `ulpi' "
"or `tsec1'.\n", mpc8315erdb);
return;
}
ret = fdt_path_offset(fdt, "/aliases");