u-boot/tools/buildman/control.py

473 lines
18 KiB
Python
Raw Normal View History

# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2013 The Chromium OS Authors.
#
"""Control module for buildman
This holds the main control logic for buildman, when not running tests.
"""
import multiprocessing
import os
import shutil
import sys
from buildman import boards
from buildman import bsettings
from buildman import cfgutil
from buildman import toolchain
from buildman.builder import Builder
from patman import gitutil
from patman import patchstream
from u_boot_pylib import command
from u_boot_pylib import terminal
from u_boot_pylib.terminal import tprint
TEST_BUILDER = None
def get_plural(count):
"""Returns a plural 's' if count is not 1"""
return 's' if count != 1 else ''
def get_action_summary(is_summary, commits, selected, options):
"""Return a string summarising the intended action.
Returns:
Summary string.
"""
if commits:
count = len(commits)
count = (count + options.step - 1) // options.step
commit_str = f'{count} commit{get_plural(count)}'
else:
commit_str = 'current source'
msg = (f"{'Summary of' if is_summary else 'Building'} "
f'{commit_str} for {len(selected)} boards')
msg += (f' ({options.threads} thread{get_plural(options.threads)}, '
f'{options.jobs} job{get_plural(options.jobs)} per thread)')
return msg
# pylint: disable=R0913
def show_actions(series, why_selected, boards_selected, output_dir, options,
board_warnings):
"""Display a list of actions that we would take, if not a dry run.
Args:
series: Series object
why_selected: Dictionary where each key is a buildman argument
provided by the user, and the value is the list of boards
brought in by that argument. For example, 'arm' might bring
in 400 boards, so in this case the key would be 'arm' and
the value would be a list of board names.
boards_selected: Dict of selected boards, key is target name,
value is Board object
output_dir (str): Output directory for builder
options: Command line options object
board_warnings: List of warnings obtained from board selected
"""
col = terminal.Color()
print('Dry run, so not doing much. But I would do this:')
print()
if series:
commits = series.commits
else:
commits = None
print(get_action_summary(False, commits, boards_selected,
options))
print(f'Build directory: {output_dir}')
if commits:
for upto in range(0, len(series.commits), options.step):
commit = series.commits[upto]
print(' ', col.build(col.YELLOW, commit.hash[:8], bright=False), end=' ')
print(commit.subject)
print()
for arg in why_selected:
if arg != 'all':
print(arg, f': {len(why_selected[arg])} boards')
if options.verbose:
print(f" {' '.join(why_selected[arg])}")
print('Total boards to build for each '
f"commit: {len(why_selected['all'])}\n")
if board_warnings:
for warning in board_warnings:
print(col.build(col.YELLOW, warning))
def show_toolchain_prefix(brds, toolchains):
"""Show information about a the tool chain used by one or more boards
The function checks that all boards use the same toolchain, then prints
the correct value for CROSS_COMPILE.
Args:
boards: Boards object containing selected boards
toolchains: Toolchains object containing available toolchains
Return:
None on success, string error message otherwise
"""
board_selected = brds.get_selected_dict()
tc_set = set()
for brd in board_selected.values():
tc_set.add(toolchains.Select(brd.arch))
if len(tc_set) != 1:
return 'Supplied boards must share one toolchain'
tchain = tc_set.pop()
print(tchain.GetEnvArgs(toolchain.VAR_CROSS_COMPILE))
return None
def get_allow_missing(opt_allow, opt_no_allow, num_selected, has_branch):
"""Figure out whether to allow external blobs
Uses the allow-missing setting and the provided arguments to decide whether
missing external blobs should be allowed
Args:
opt_allow (bool): True if --allow-missing flag is set
opt_no_allow (bool): True if --no-allow-missing flag is set
num_selected (int): Number of selected board
has_branch (bool): True if a git branch (to build) has been provided
Returns:
bool: True to allow missing external blobs, False to produce an error if
external blobs are used
"""
allow_missing = False
am_setting = bsettings.GetGlobalItemValue('allow-missing')
if am_setting:
if am_setting == 'always':
allow_missing = True
if 'multiple' in am_setting and num_selected > 1:
allow_missing = True
if 'branch' in am_setting and has_branch:
allow_missing = True
if opt_allow:
allow_missing = True
if opt_no_allow:
allow_missing = False
return allow_missing
def determine_series(count, has_range, branch, git_dir):
"""Determine the series which is to be built, if any
Args:
count (int): Number of commits in branch
has_range (bool): True if a range of commits ('xx..yy') is being built
branch (str): Name of branch to build, or None if none
git_dir (str): Git directory to use, e.g. './.git'
Returns:
Series: Series to build, or None for none
Read the metadata from the commits. First look at the upstream commit,
then the ones in the branch. We would like to do something like
upstream/master~..branch but that isn't possible if upstream/master is
a merge commit (it will list all the commits that form part of the
merge)
Conflicting tags are not a problem for buildman, since it does not use
them. For example, Series-version is not useful for buildman. On the
other hand conflicting tags will cause an error. So allow later tags
to overwrite earlier ones by setting allow_overwrite=True
"""
if branch:
if count == -1:
if has_range:
range_expr = branch
else:
range_expr = gitutil.get_range_in_branch(git_dir, branch)
upstream_commit = gitutil.get_upstream(git_dir, branch)
series = patchstream.get_metadata_for_list(upstream_commit,
git_dir, 1, series=None, allow_overwrite=True)
series = patchstream.get_metadata_for_list(range_expr,
git_dir, None, series, allow_overwrite=True)
else:
# Honour the count
series = patchstream.get_metadata_for_list(branch,
git_dir, count, series=None, allow_overwrite=True)
else:
series = None
return series
def do_fetch_arch(toolchains, col, fetch_arch):
"""Handle the --fetch-arch option
Args:
toolchains (Toolchains): Tool chains to use
col (terminal.Color): Color object to build
fetch_arch (str): Argument passed to the --fetch-arch option
Returns:
int: Return code for buildman
"""
if fetch_arch == 'list':
sorted_list = toolchains.ListArchs()
print(col.build(
col.BLUE,
f"Available architectures: {' '.join(sorted_list)}\n"))
return 0
if fetch_arch == 'all':
fetch_arch = ','.join(toolchains.ListArchs())
print(col.build(col.CYAN,
f'\nDownloading toolchains: {fetch_arch}'))
for arch in fetch_arch.split(','):
print()
ret = toolchains.FetchAndInstall(arch)
if ret:
return ret
return 0
def do_buildman(options, args, toolchains=None, make_func=None, brds=None,
clean_dir=False, test_thread_exceptions=False):
"""The main control code for buildman
Args:
options: Command line options object
args: Command line arguments (list of strings)
toolchains: Toolchains to use - this should be a Toolchains()
object. If None, then it will be created and scanned
make_func: Make function to use for the builder. This is called
to execute 'make'. If this is None, the normal function
will be used, which calls the 'make' tool with suitable
arguments. This setting is useful for tests.
brds: Boards() object to use, containing a list of available
boards. If this is None it will be created and scanned.
clean_dir: Used for tests only, indicates that the existing output_dir
should be removed before starting the build
test_thread_exceptions: Uses for tests only, True to make the threads
raise an exception instead of reporting their result. This simulates
a failure in the code somewhere
"""
# Used so testing can obtain the builder: pylint: disable=W0603
global TEST_BUILDER
gitutil.setup()
col = terminal.Color()
git_dir = os.path.join(options.git, '.git')
no_toolchains = toolchains is None
if no_toolchains:
toolchains = toolchain.Toolchains(options.override_toolchain)
if options.fetch_arch:
return do_fetch_arch(toolchains, col, options.fetch_arch)
if no_toolchains:
toolchains.GetSettings()
toolchains.Scan(options.list_tool_chains and options.verbose)
if options.list_tool_chains:
toolchains.List()
print()
return 0
if not options.output_dir:
if options.work_in_output:
sys.exit(col.build(col.RED, '-w requires that you specify -o'))
options.output_dir = '..'
nr_cups = options.threads or multiprocessing.cpu_count()
# Work out what subset of the boards we are building
if not brds:
if not os.path.exists(options.output_dir):
os.makedirs(options.output_dir)
board_file = os.path.join(options.output_dir, 'boards.cfg')
if options.regen_board_list and options.regen_board_list != '-':
board_file = options.regen_board_list
brds = boards.Boards()
if options.maintainer_check:
warnings = brds.build_board_list(jobs=nr_cups)[1]
if warnings:
for warn in warnings:
print(warn, file=sys.stderr)
return 2
return 0
okay = brds.ensure_board_list(
board_file,
options.threads or multiprocessing.cpu_count(),
force=options.regen_board_list,
quiet=not options.verbose)
if options.regen_board_list:
return 0 if okay else 2
brds.read_boards(board_file)
exclude = []
if options.exclude:
for arg in options.exclude:
exclude += arg.split(',')
if options.boards:
requested_boards = []
for brd in options.boards:
requested_boards += brd.split(',')
else:
requested_boards = None
why_selected, board_warnings = brds.select_boards(args, exclude,
requested_boards)
selected = brds.get_selected()
if not selected:
sys.exit(col.build(col.RED, 'No matching boards found'))
if options.print_prefix:
err = show_toolchain_prefix(brds, toolchains)
if err:
sys.exit(col.build(col.RED, err))
return 0
# Work out how many commits to build. We want to build everything on the
# branch. We also build the upstream commit as a control so we can see
# problems introduced by the first commit on the branch.
count = options.count
has_range = options.branch and '..' in options.branch
if count == -1:
if not options.branch:
count = 1
else:
if has_range:
count, msg = gitutil.count_commits_in_range(git_dir,
options.branch)
else:
count, msg = gitutil.count_commits_in_branch(git_dir,
options.branch)
if count is None:
sys.exit(col.build(col.RED, msg))
elif count == 0:
sys.exit(col.build(col.RED,
f"Range '{options.branch}' has no commits"))
if msg:
print(col.build(col.YELLOW, msg))
count += 1 # Build upstream commit also
if not count:
msg = (f"No commits found to process in branch '{options.branch}': "
"set branch's upstream or use -c flag")
sys.exit(col.build(col.RED, msg))
if options.work_in_output:
if len(selected) != 1:
sys.exit(col.build(col.RED,
'-w can only be used with a single board'))
if count != 1:
sys.exit(col.build(col.RED,
'-w can only be used with a single commit'))
series = determine_series(count, has_range, options.branch, git_dir)
if not series and not options.dry_run:
options.verbose = True
if not options.summary:
options.show_errors = True
# By default we have one thread per CPU. But if there are not enough jobs
# we can have fewer threads and use a high '-j' value for make.
if options.threads is None:
options.threads = min(multiprocessing.cpu_count(), len(selected))
if not options.jobs:
options.jobs = max(1, (multiprocessing.cpu_count() +
len(selected) - 1) // len(selected))
if not options.step:
options.step = len(series.commits) - 1
gnu_make = command.output(os.path.join(options.git,
'scripts/show-gnu-make'), raise_on_error=False).rstrip()
if not gnu_make:
sys.exit('GNU Make not found')
allow_missing = get_allow_missing(options.allow_missing,
options.no_allow_missing, len(selected),
options.branch)
# Create a new builder with the selected options.
output_dir = options.output_dir
if options.branch:
dirname = options.branch.replace('/', '_')
# As a special case allow the board directory to be placed in the
# output directory itself rather than any subdirectory.
if not options.no_subdirs:
output_dir = os.path.join(options.output_dir, dirname)
if clean_dir and os.path.exists(output_dir):
shutil.rmtree(output_dir)
adjust_cfg = cfgutil.convert_list_to_dict(options.adjust_cfg)
# Drop LOCALVERSION_AUTO since it changes the version string on every commit
if options.reproducible_builds:
# If these are mentioned, leave the local version alone
if 'LOCALVERSION' in adjust_cfg or 'LOCALVERSION_AUTO' in adjust_cfg:
print('Not dropping LOCALVERSION_AUTO for reproducible build')
else:
adjust_cfg['LOCALVERSION_AUTO'] = '~'
builder = Builder(toolchains, output_dir, git_dir,
options.threads, options.jobs, gnu_make=gnu_make, checkout=True,
show_unknown=options.show_unknown, step=options.step,
no_subdirs=options.no_subdirs, full_path=options.full_path,
buildman: allow more incremental building One use-case for buildman is to continually run it interactively after each small step in a large refactoring operation. This gives more immediate feedback than making a number of commits and then going back and testing them. For this to work well, buildman needs to be extremely fast. At present, a couple issues prevent it being as fast as it could be: 1) Each time buildman runs "make %_defconfig", it runs "make mrproper" first. This throws away all previous build results, requiring a from-scratch build. Optionally avoiding this would speed up the build, at the cost of potentially causing or missing some build issues. 2) A build tree is created per thread rather than per board. When a thread switches between building different boards, this often causes many files to be rebuilt due to changing config options. Using a separate build tree for each board would avoid this. This does put more strain on the system's disk cache, but it is worth it on my system at least. This commit adds two command-line options to implement the changes described above; -I ("--incremental") turns of "make mrproper" and -P ("--per-board-out-dir") creats a build directory per board rather than per thread. Tested: ./tools/buildman/buildman.py tegra ./tools/buildman/buildman.py -I -P tegra ./tools/buildman/buildman.py -b tegra_dev tegra ./tools/buildman/buildman.py -b tegra_dev -I -P tegra ... each once after deleting the buildman result/work directory, and once "incrementally" after a previous identical invocation. Signed-off-by: Stephen Warren <swarren@nvidia.com> Reviewed-by: Tom Rini <trini@konsulko.com> Acked-by: Simon Glass <sjg@chromium.org> # v1 Tested-by: Simon Glass <sjg@chromium.org> # v1 Acked-by: Simon Glass <sjg@chromium.org>
2016-04-11 16:48:44 +00:00
verbose_build=options.verbose_build,
mrproper=options.mrproper,
per_board_out_dir=options.per_board_out_dir,
config_only=options.config_only,
squash_config_y=not options.preserve_config_y,
warnings_as_errors=options.warnings_as_errors,
work_in_output=options.work_in_output,
test_thread_exceptions=test_thread_exceptions,
adjust_cfg=adjust_cfg,
allow_missing=allow_missing, no_lto=options.no_lto,
reproducible_builds=options.reproducible_builds)
TEST_BUILDER = builder
builder.force_config_on_failure = not options.quick
if make_func:
builder.do_make = make_func
# For a dry run, just show our actions as a sanity check
if options.dry_run:
show_actions(series, why_selected, selected, output_dir, options,
board_warnings)
else:
builder.force_build = options.force_build
builder.force_build_failures = options.force_build_failures
builder.force_reconfig = options.force_reconfig
builder.in_tree = options.in_tree
# Work out which boards to build
board_selected = brds.get_selected_dict()
if series:
commits = series.commits
# Number the commits for test purposes
for i, commit in enumerate(commits):
commit.sequence = i
else:
commits = None
if not options.ide:
tprint(get_action_summary(options.summary, commits, board_selected,
options))
# We can't show function sizes without board details at present
if options.show_bloat:
options.show_detail = True
builder.SetDisplayOptions(
options.show_errors, options.show_sizes, options.show_detail,
options.show_bloat, options.list_error_boards, options.show_config,
options.show_environment, options.filter_dtb_warnings,
options.filter_migration_warnings, options.ide)
if options.summary:
builder.ShowSummary(commits, board_selected)
else:
fail, warned, excs = builder.BuildBoards(
commits, board_selected, options.keep_outputs, options.verbose)
if excs:
return 102
if fail:
return 100
if warned and not options.ignore_warnings:
return 101
return 0